Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Euclidean should support local_metric in DefaultOrthonormalBasis #742

Open
r0uv3n opened this issue Sep 12, 2024 · 3 comments
Open

Euclidean should support local_metric in DefaultOrthonormalBasis #742

r0uv3n opened this issue Sep 12, 2024 · 3 comments

Comments

@r0uv3n
Copy link
Contributor

r0uv3n commented Sep 12, 2024

Currently, local_metric only works for manifolds of type Euclidean when using an InducedBasis. For consistency I think it might be nice to have this return the same thing for the DefaultOrthonormalBasis, which seems to be used by most internal methods by default, e.g. solve_exp_ode.

@kellertuer
Copy link
Member

sounds reasonable – especially since for Euclidean this is very easy (you even could consider just using DiffEq per se then). Do you feel you could do an PR for this as well (or in your PR you plan to do)?

If you are stuck somewhere we can help for sure (also with getting started with PRs and such).

@mateuszbaran
Copy link
Member

Yes, support for local_metric is somewhat incomplete at the moment. It should definitely also work with DefaultOrthonormalBasis. Note though that DefaultOrthonormalBasis is in general not designed to work well with local_metric on all manifolds. Its main purpose is "I have a point, and I want to quickly transform tangent vectors into their coordinates and the other way around". As a result, not much attention is paid to the choice being continuous/differentiable/smooth between different points. For metric-related functions some level of smoothness is generally desirable and InducedBasis was introduced as a way to (locally) guarantee it.

@r0uv3n
Copy link
Contributor Author

r0uv3n commented Sep 14, 2024

Okay I'll leave this to you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants