Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation clarification #745

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Conversation

olivierverdier
Copy link
Contributor

Fixes #743

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.69%. Comparing base (fa36c54) to head (e6b509e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #745   +/-   ##
=======================================
  Coverage   99.69%   99.69%           
=======================================
  Files         123      123           
  Lines       11415    11415           
=======================================
  Hits        11380    11380           
  Misses         35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kellertuer
Copy link
Member

Thanks for the quick fix. Do you want to add a small entry for the changelog as well? Though a “typos fixed” one might be there after merging #741 anyways.

@olivierverdier
Copy link
Contributor Author

It's easier for me if you merge as is, if possible? But feel free to add an entry to the changelog if you think it's necessary.

@kellertuer
Copy link
Member

Hm, now that you seem to have the news entry (sorry I accidentally had that on master, made a mistake there) we have a merge conflict here, but if you reset / resolve that, sure I can merge.

@kellertuer
Copy link
Member

Ah I can edit myself. Then I can merge this now as well. Thanks for fixing!

@kellertuer kellertuer merged commit fe3e49d into JuliaManifolds:master Sep 12, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discrepancy in documentation: at what point is vector X in translate_diff
2 participants