Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translate_diff documentation clarification #746

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

olivierverdier
Copy link
Contributor

The order in description and equations was confusing

The order in description and equations was confusing
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.69%. Comparing base (fe3e49d) to head (1ff3a35).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #746   +/-   ##
=======================================
  Coverage   99.69%   99.69%           
=======================================
  Files         123      123           
  Lines       11415    11415           
=======================================
  Hits        11380    11380           
  Misses         35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Better show the definition of ``τ_p``
@kellertuer
Copy link
Member

Thanks, now I also understand all 4 cases – I was a bit lost in the old description and hence even did not follow up on the corresponding PR then any longer – now it makes more sense for the as well – thanks for fixing that!

@kellertuer kellertuer merged commit 11f0a6c into JuliaManifolds:master Sep 13, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants