Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix solve_exp_ode not updating position #748

Merged
merged 4 commits into from
Sep 15, 2024

Conversation

r0uv3n
Copy link
Contributor

@r0uv3n r0uv3n commented Sep 14, 2024

Fixes #744 and fixes #740. Also add some new tests that fail without the fix for #744.

@kellertuer
Copy link
Member

Nice!

The one small hint failing is an entry in the changeling (NEWS.md), if you could add that as well, this looks perfect!

Copy link

codecov bot commented Sep 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.69%. Comparing base (11f0a6c) to head (f58a168).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #748   +/-   ##
=======================================
  Coverage   99.69%   99.69%           
=======================================
  Files         123      123           
  Lines       11415    11415           
=======================================
  Hits        11380    11380           
  Misses         35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r0uv3n
Copy link
Contributor Author

r0uv3n commented Sep 14, 2024

Should I just add a new minor version number for this?

@kellertuer
Copy link
Member

yes, as date you could put “unreleased” we will add the date when we register the new version; for the rest just follow the scheme that is already there :)

Copy link
Member

@kellertuer kellertuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for your contribution!

Copy link
Member

@mateuszbaran mateuszbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks right to me.

@kellertuer kellertuer merged commit 43b6990 into JuliaManifolds:master Sep 15, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

solve_exp_ode does not ever update position solve_exp_ode has wrong function signature in docs
3 participants