Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevents creation of Windows Start Menu items #254

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Prevents creation of Windows Start Menu items #254

merged 1 commit into from
Jun 25, 2024

Conversation

RoyiAvital
Copy link
Contributor

Using the updated cli flags for the installer as documented in https://conda.github.io/constructor/cli-options.

Related to #147.

Using the updated `cli` flags for the installer as documented in https://conda.github.io/constructor/cli-options.
@RoyiAvital
Copy link
Contributor Author

@stevengj , Any chance moving this forward?

@ViralBShah
Copy link
Collaborator

This appears like it could be correct (but I can't easily find the relevant documentation to verify). Since the CI is passing, I feel it is ok to merge it.

@ViralBShah ViralBShah merged commit 005a8ea into JuliaPy:master Jun 25, 2024
9 checks passed
@RoyiAvital
Copy link
Contributor Author

@ViralBShah , From the link above:

image

Thanks for merging.

@ViralBShah
Copy link
Collaborator

I've released a new version as well with this fix. Thanks.

@RoyiAvital
Copy link
Contributor Author

Looking at the documentation it seems the order of /S and the other flags is not as advised.

I will create a new pull.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants