Force propertynames(::Py) to occur on the main thread
#677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bump. Tentatively pinging @cjdoris if you don't mind? |
|
Thank you. I was hesitant but I've merged it as a sticking plaster for now - you're right that these crashes are now difficult to avoid on Julia 1.12. I just opened #697 as a more drastic solution to this (but also to enable multi-threading more generally). |
|
Great, thank you! Of course I'm more than happy to see this removed later for a more general solution, but if it can at least ensure that no crash occurs in the middle of an innocent REPL session in the meantime, that's already a clear win. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #586 by implementing something akin to #586 (comment). The idea consists in forwarding the content of
propertynames(::Py)to a task that is forced to run on the main thread.Tested on julia 1.10, 1.11 and 1.12.0-rc2 with different number of default/interactive threads.
Since they are duplicates, also close #591, close #611 and close #631.