Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New s3 validatekey fails when you have a presigned URL #38

Open
quinnj opened this issue Apr 11, 2023 · 1 comment
Open

New s3 validatekey fails when you have a presigned URL #38

quinnj opened this issue Apr 11, 2023 · 1 comment

Comments

@quinnj
Copy link
Member

quinnj commented Apr 11, 2023

cc: @Drvi

@quinnj
Copy link
Member Author

quinnj commented Apr 11, 2023

I noticed this during some drive-by testing; if you generate a pre-signed URL for an s3 object, the validatekey function will fail because the urls are often > 1024 characters, because we're currently including the object name and everything after it in the URL as the "key". We need to maybe call URIs.URI so we can split out the query portion of the url before passing to validatekey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant