Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter hashes that are unlikely to be useful #7

Open
raboof opened this issue Feb 26, 2024 · 3 comments
Open

filter hashes that are unlikely to be useful #7

raboof opened this issue Feb 26, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@raboof
Copy link
Collaborator

raboof commented Feb 26, 2024

Some hashes will be unlikely to be useful to share, as they are specific to users' configurations.

Could we somehow identify those and avoid uploading them? Or perhaps periodically garbage-collect 'old' hashes that only appear once?

@JulienMalka
Copy link
Owner

JulienMalka commented Feb 26, 2024

I was thinking we should evaluate nixpkgs revisions that hydra evaluates, or parse hydra evaluation results in order to only accept derivations from nixpkgs. This is also a matter of privacy because currently we are also storing derivation names, which can carry information.

@raboof
Copy link
Collaborator Author

raboof commented Feb 26, 2024

I was thinking we should evaluate nixpkgs revisions that hydra evaluates, or parse hydra evaluation results in order to only accept derivations from nixpkgs. This is also a matter of privacy because currently we are also storing derivation names, which can carry information.

That seems like a good start to me.

If we implement that on the server side, there could be a race between rebuilders and #6 (or whatever process we use to determine which derivations are from nixpkgs), so perhaps we should do this in the build-hook at least initially?

@raboof raboof added the enhancement New feature or request label Feb 26, 2024
@raboof
Copy link
Collaborator Author

raboof commented Mar 21, 2024

Maybe as a first first step we should give the build-hook a 'whitelist' parameter that we can use to only upload builds that are part of a report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants