Fix GUI layout issues with scaling #4316
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Bug
|
Easy test build link here: @linuxgurugamer, could you please try that build and check whether it helps at all with #4308? @spirritus, could you please try that build and check whether it helps at all with #4271? @pablogila, could you please try that build and check whether it helps at all with #878? |
|
But this is the windows build, the #878 had problems in the linux one... |
|
@pablogila, there is no "Linux build", it's the same exe file on all platforms. Just run it with Mono. |
|
Well I'm afraid I don't know what Mono is. I just followed the CKAN install instructions for Linux |
|
|
HebaruSan
force-pushed
the
fix/gui-scaling
branch
4 times, most recently
from
25b0385 to
b60fe08
Compare
HebaruSan
force-pushed
the
fix/gui-scaling
branch
from
c0e2e92 to
a9765c5
Compare
|
@HebaruSan I confirm that the problem persists, the GUI is also tiny using the Mono version that you provided before. |
|
Darn, oh well. Thanks for taking a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems
suppress_recommendationson a relationship (typically in a modpack), that mod's recommendations and suggestions aren't shown, but its supported-by mods still are.Causes
supportsrelationships are handled differently from recommendations and suggestions in a way that requires a separate solution to suppression, which wasn't done previously.OnHoverevent. Maybe this causes a delay while you're clicking (not 100% certain about this, but it's the lowest hanging fruit to try first).Changes
AutoScaleDimensionsandAutoScaleModein most dialogs and controls to enable automatic scaling. In addition, some layout is re-worked to use docking instead of anchoring.Does not address Font Rescaling #878.Fixes [Bug]: UI Scaling on Linux (KDE) partially broken #4271 (maybe, needs confirmation).
supress_recommendationsalso applies tosupportsrelationships (requested by @JonnyOThan on Discord).OnOpenevent rather than inMouseHover, so it should be less disruptive to usage of that button.Fixes [Bug]: Clicking quickly on Play button doesn't play game #4308 (maybe, needs confirmation).
SingleAssemblyResourceManagerin CmdLine, ConsoleUI, and GUI are removed and replaced by re-using the one in Core.LeftRightRowPanelnow forces each half to be 50% to work around some weird quirks of Mono's layout logic.ErrorDialognow invokes the GUI thread using a reference to the main form instead of itself, which fixes a crash I noticed during development.