Another fix, this time on the ReloadingDatabase dialogbox.

Author: Lisias

Source/ModuleManager/GUI/ReloadingDatabase.12.cs

@@ -14,9 +14,9 @@ namespace ModuleManager.GUI
 #if KSP12
 	public class ReloadingDatabaseDialog
 	{
-		internal static ReloadingDatabaseDialog Show(ModuleManager parent, bool startedReload)
+		internal static ReloadingDatabaseDialog Show(ModuleManager parent)
 		{
-			return new ReloadingDatabaseDialog(parent, startedReload);
+			return new ReloadingDatabaseDialog(parent);
 		}
 
 		internal Menu Dismiss()
@@ -28,7 +28,7 @@ internal Menu Dismiss()
 
 		private ModuleManager parent;
 		private PopupDialog instance;
-		private ReloadingDatabaseDialog(ModuleManager parent, bool startedReload)
+		private ReloadingDatabaseDialog(ModuleManager parent)
 		{
 			this.parent = parent;
 		}

Source/ModuleManager/GUI/ReloadingDatabase.cs

@@ -14,9 +14,9 @@ namespace ModuleManager.GUI
 #if !KSP12
 	public class ReloadingDatabaseDialog
 	{
-		internal static ReloadingDatabaseDialog Show(ModuleManager parent, bool startedReload)
+		internal static ReloadingDatabaseDialog Show(ModuleManager parent)
 		{
-			return new ReloadingDatabaseDialog(parent, startedReload);
+			return new ReloadingDatabaseDialog(parent);
 		}
 
 		internal Menu Dismiss()
@@ -28,8 +28,9 @@ internal Menu Dismiss()
 
 		private ModuleManager parent;
 		private PopupDialog instance;
-		private ReloadingDatabaseDialog(ModuleManager parent, bool startedReload)
+		private ReloadingDatabaseDialog(ModuleManager parent)
 		{
+			bool startedReload = false;
 			this.parent = parent;
 
 			UISkinDef skinDef = HighLogic.UISkin;
@@ -73,6 +74,7 @@ private ReloadingDatabaseDialog(ModuleManager parent, bool startedReload)
 							if (!startedReload)
 							{
 								progressFraction = 0f;
+								startedReload = true;
 							}
 							else if (!GameDatabase.Instance.IsReady() || !PostPatchLoader.Instance.IsReady())
 							{

Source/ModuleManager/ModuleManager.cs

@@ -277,21 +277,16 @@ public static bool IsABadIdea()
 		internal IEnumerator DataBaseReloadWithMM(bool dump = false)
 		{
 			PerformanceMetrics.Instance.Start();
+			GUI.ReloadingDatabaseDialog reloadingDialog = GUI.ReloadingDatabaseDialog.Show(this);
 			try
 			{
 				patchRunner = new MMPatchRunner(ModLogger.Instance);
 
-				bool startedReload = false;
-
-				GUI.ReloadingDatabaseDialog reloadingDialog = GUI.ReloadingDatabaseDialog.Show(this, startedReload);
-
 				yield return null;
 
 				GameDatabase.Instance.Recompile = true;
 				GameDatabase.Instance.StartLoad();
 
-				startedReload = true;
-
 				yield return null;
 				StartCoroutine(patchRunner.Run());
 
@@ -325,12 +320,11 @@ internal IEnumerator DataBaseReloadWithMM(bool dump = false)
 				//		ResearchAndDevelopment.Instance.OnLoad(scenario);
 				//	}
 				//}
-
-				reloadingDialog.Dismiss();
 			}
 			finally
 			{
 				PerformanceMetrics.Instance.Stop();
+				reloadingDialog.Dismiss();
 				Log("Total reloading Time = " + PerformanceMetrics.Instance.ElapsedTimeInSecs.ToString("F3") + "s");
 				PerformanceMetrics.Instance.Destroy();
 			}