Merge pull request sarbian#171 from al2me6/fix-index-checking

sarbian · web-flow · commit e9d12d1d4d66 · 2021-08-01T21:51:56.000+02:00
Fix off-by-one string indexing in constraint checking
diff --git a/ModuleManager/MMPatchLoader.cs b/ModuleManager/MMPatchLoader.cs
@@ -1548,7 +1548,7 @@ public static bool CheckConstraints(ConfigNode node, string constraints)
                 string remainingConstraints = "";
                 if (constraints.Contains(":HAS[", out int hasStart))
                 {
-                    hasStart += 4;
+                    hasStart += 5;
                     remainingConstraints = constraints.Substring(hasStart, constraintList[0].LastIndexOf(']') - hasStart);
                     constraints = constraints.Substring(0, hasStart - 5);
                 }

Original file line number	Diff line number	Diff line change
`@@ -1548,7 +1548,7 @@ public static bool CheckConstraints(ConfigNode node, string constraints)`
`1548`	`1548`	`string remainingConstraints = "";`
`1549`	`1549`	`if (constraints.Contains(":HAS[", out int hasStart))`
`1550`	`1550`	`{`
`1551`		`- hasStart += 4;`
	`1551`	`+ hasStart += 5;`
`1552`	`1552`	`remainingConstraints = constraints.Substring(hasStart, constraintList[0].LastIndexOf(']') - hasStart);`
`1553`	`1553`	`constraints = constraints.Substring(0, hasStart - 5);`
`1554`	`1554`	`}`