Summary of What Needs to be Done
Multiple widgets render chart axes and dividers using hardcoded Unicode box-drawing characters without checking caps.unicode:
packages/widgets/src/data/LineChart.ts - Y-axis tick marks (│, ┤), vertical connectors (│), X-axis line (─), origin corner (└) all lack ASCII fallback.
packages/widgets/src/layout/SplitPane.ts - Vertical split divider uses hardcoded ─ instead of caps.unicode check.
Changes that Need to be Made
- LineChart.ts: Update all axis and connector rendering in
_renderSelf() to use caps.unicode ? '│' : '|', caps.unicode ? '─' : '-', and caps.unicode ? '└' : '+' for the origin corner.
- SplitPane.ts: Update vertical split divider to use
caps.unicode ? '─' : '-'.
- Add tests for both widgets verifying ASCII fallback rendering.
Impact that it would Provide
LineChart and SplitPane will render correctly in non-Unicode terminals, ensuring layout and chart widgets work across all terminal environments.
Note: Please assign this issue to the tmdeveloper007 account.
Summary of What Needs to be Done
Multiple widgets render chart axes and dividers using hardcoded Unicode box-drawing characters without checking
caps.unicode:packages/widgets/src/data/LineChart.ts- Y-axis tick marks (│,┤), vertical connectors (│), X-axis line (─), origin corner (└) all lack ASCII fallback.packages/widgets/src/layout/SplitPane.ts- Vertical split divider uses hardcoded─instead ofcaps.unicodecheck.Changes that Need to be Made
_renderSelf()to usecaps.unicode ? '│' : '|',caps.unicode ? '─' : '-', andcaps.unicode ? '└' : '+'for the origin corner.caps.unicode ? '─' : '-'.Impact that it would Provide
LineChart and SplitPane will render correctly in non-Unicode terminals, ensuring layout and chart widgets work across all terminal environments.
Note: Please assign this issue to the
tmdeveloper007account.