Skip to content

Update basisu to v2.1.0#1170

Merged
MarkCallow merged 10 commits into
mainfrom
update_basisu_to_2_1_0
May 14, 2026
Merged

Update basisu to v2.1.0#1170
MarkCallow merged 10 commits into
mainfrom
update_basisu_to_2_1_0

Conversation

@MarkCallow
Copy link
Copy Markdown
Collaborator

@MarkCallow MarkCallow commented May 14, 2026

No description provided.

MarkCallow added 7 commits May 10, 2026 15:12
@MarkCallow
git subrepo clone --branch=fixes_for_ktx --force https://github.com/K…
b8a0a7f 
…hronosGroup/basis_universal.git external/basis_universal

subrepo:
  subdir:   "external/basis_universal"
  merged:   "975391104"
upstream:
  origin:   "https://github.com/KhronosGroup/basis_universal.git"
  branch:   "fixes_for_ktx"
  commit:   "975391104"
git-subrepo:
  version:  "0.4.9"
  origin:   "https://github.com/MarkCallow/git-subrepo.git"
  commit:   "4f60dd7"
@MarkCallow
Changes for Basis Universal 2.1.0.
205b940 
* Remove check for unsupported stream semantic version in UASTC 6x6i as,
  with this update, it is now supported.
* Adapt to member name changes in basisu_encoder cparams class.
@MarkCallow
Fix unused-but-set-global warning raised by Emscripten/Clang.
6bc1287 
Only define the variable when BASISU_WASI_THREADS is defined.
@MarkCallow
Update basis_tex_format names.
34ccacc
@MarkCallow
Update parent because of rebase.
381559b
@MarkCallow
Fix unused parameter warning introduced by earlier commit.
bfd353b
@MarkCallow
git subrepo push external/basis_universal
37c29e0 
subrepo:
  subdir:   "external/basis_universal"
  merged:   "a660e7be1"
upstream:
  origin:   "https://github.com/KhronosGroup/basis_universal.git"
  branch:   "fixes_for_ktx"
  commit:   "a660e7be1"
git-subrepo:
  version:  "0.4.9"
  origin:   "https://github.com/MarkCallow/git-subrepo.git"
  commit:   "4f60dd7"
@MarkCallow MarkCallow mentioned this pull request May 14, 2026
Closed
@solbjorn
Copy link
Copy Markdown

solbjorn commented May 14, 2026

Pls make sure you always handle m_ktx2_and_basis_srgb_transfer_function correctly as BasisU 2.0 changed the default value (unless the branch you're based this PR on handles it differently) (just a reminder from my comment under the previous PR).

Also, why not the HEAD commit of BasisU, but HEAD~46? I've seen several fixes there in the last couple weeks which might be important (can't say for sure).

@MarkCallow
Copy link
Copy Markdown
Collaborator Author

MarkCallow commented May 14, 2026 •
edited
Loading

Pls make sure you always handle m_ktx2_and_basis_srgb_transfer_function correctly as BasisU 2.0 changed the default value (unless the branch you're based this PR on handles it differently) (just a reminder from my comment under the previous PR).

Looking into this. Thanks for pointing it out again.

Also, why not the HEAD commit of BasisU, but HEAD~46? I've seen several fixes there in the last couple weeks which might be important (can't say for sure).

Because we want the latest release for more stability especially as we are about to make a release.

@MarkCallow
Set m_ktx2_and_basis_srgb_transfer_function false when not sRGB.
c9b96fe 
It previously defaulted to false to false so this was not necessary.
@MarkCallow
Copy link
Copy Markdown
Collaborator Author

MarkCallow commented May 14, 2026 •
edited
Loading

Pls make sure you always handle m_ktx2_and_basis_srgb_transfer_function correctly as BasisU 2.0 changed the default value (unless the branch you're based this PR on handles it differently) (just a reminder from my comment under the previous PR).

I committed a change to set it to false for non-sRGB but it does not make any difference to the results because basisu_encoder only uses it to determine what transfer function metadata to write to the output file and libktx writes the .ktx2 file itself. The perceptual param controls data handling in the encoder and we were already setting that false.

@MarkCallow MarkCallow merged commit 1dacc4b into main May 14, 2026
41 checks passed
@MarkCallow MarkCallow deleted the update_basisu_to_2_1_0 branch May 14, 2026 08:12
@MarkCallow MarkCallow mentioned this pull request May 14, 2026
Draft
28 tasks
@solbjorn
Copy link
Copy Markdown

solbjorn commented May 14, 2026

@MarkCallow, I see, thanks! Glad it's finally merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MarkCallow @solbjorn