Skip to content

Commit 565d68e

Browse files
committed
fix for windows building in CI.
1 parent 3938e49 commit 565d68e

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

attachments/advanced_gltf/CMakeLists.txt

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,9 @@ FetchContent_Declare(
8080
SOURCE_SUBDIR Build)
8181
set(DOUBLE_PRECISION OFF CACHE BOOL "" FORCE)
8282
set(GENERATE_DEBUG_SYMBOLS ON CACHE BOOL "" FORCE)
83+
if(MSVC)
84+
set(USE_STATIC_MSVC_RUNTIME_LIBRARY OFF CACHE BOOL "" FORCE)
85+
endif()
8386
FetchContent_MakeAvailable(JoltPhysics)
8487

8588
# ---------------------------------------------------------------------------
@@ -244,9 +247,9 @@ if(MSVC)
244247
# NOMINMAX needs to inherit so MSVC doesn't have problems with min / max being a MSVC macro.
245248
target_compile_definitions(SimpleEngineLib PUBLIC
246249
NOMINMAX WIN32_LEAN_AND_MEAN _CRT_SECURE_NO_WARNINGS)
247-
target_compile_options(SimpleEngineLib PRIVATE
250+
target_compile_options(SimpleEngineLib PUBLIC
248251
/permissive- /Zc:__cplusplus /EHsc /W3 /MP /bigobj)
249-
target_link_libraries(SimpleEngineLib PRIVATE Dbghelp)
252+
target_link_libraries(SimpleEngineLib PUBLIC Dbghelp)
250253
elseif(WIN32)
251254
target_compile_definitions(SimpleEngineLib PUBLIC
252255
NOMINMAX WIN32_LEAN_AND_MEAN _CRT_SECURE_NO_WARNINGS)

0 commit comments

Comments
 (0)