chore: Add REUSE compliance and AI block#374
Conversation
|
Looks good to me. I do have one question though: This has Apache-2.0 as license. But that folder also contains the tutorial source, which is base on the original tutorial code that afaik is CC-BY SA. Or does the REUSE only apply to files that contain a copyright header? |
|
Yes, I did miss that in the Overview. I am thinking that not all files in |
REUSE applies to all files included in the |
| path = [ | ||
| "en/**", | ||
| ] | ||
| SPDX-FileCopyrightText = [ |
There was a problem hiding this comment.
Not sure about this. Our tutorial is based on https://github.com/Overv/VulkanTutorial, so shouldn't this somehow at least mention the author of the original Vulkan tutorial?
There was a problem hiding this comment.
Yes, that is a very good idea, thank you @SaschaWillems. Should the copyright be something along the lines of:
2023 Alexander Overvoorde
2023-2026 The Khronos Group Inc.
There was a problem hiding this comment.
Sorry, it's slightly more complicated. Alexander's original code only covers up to 10_multisampling.adoc. It shouldn't cover the rest of the tutorial. I guess I should add the Holochip copyright, but I'm fine with just leaving it as Khronos group everywhere.
| [[annotations]] | ||
| path ="attachments/**" | ||
| SPDX-FileCopyrightText = "The Khronos Group, Inc." | ||
| SPDX-License-Identifier = "Apache-2.0" |
There was a problem hiding this comment.
Should this be CC-BY-1.0 to match the old /code directory from Overv?
There was a problem hiding this comment.
Only the top level base tutorial should be CC-BY-1.0. The Simple Game Engine should be the more permissive Apache-2.0
3 participants
This repository CONTRIBUTING.adoc originally listed only CC-BY-SA-4.0. However, the repository also has Apache-2.0, CC-BY-4.0 and BSD-3-Clause.
As there are typically a lot of questions around the use of wildcards in REUSE.toml, here is a little background:
The wildcard has been put in place solely because REUSE was introduced without first updating every file. A strict configuration would have blocked any commit touching a non-compliant file, which probably would not make the maintainers very happy. The wildcard gives us a compliant baseline while headers are added at the maintainers' pace.
REUSE annotations are not just for exceptions. The REUSE spec fully supports REUSE.toml as the primary mechanism for declaring copyright and licensing. File headers are recommended, not required.