Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message with drop downs on Firefox #599

Closed
echadwick-artist opened this issue Feb 1, 2025 · 1 comment · Fixed by #602
Closed

Error message with drop downs on Firefox #599

echadwick-artist opened this issue Feb 1, 2025 · 1 comment · Fixed by #602

Comments

@echadwick-artist
Copy link
Contributor

echadwick-artist commented Feb 1, 2025

iPhone 13 mini
Firefox 134.1

  1. Open browser.
  2. go to sample viewer
  3. Choose any model with variants, for example GlamVelvetSofa
  4. Tap on the variants dropdown

Result = A pink message appears with a script error (see attached screenshot)

The error pops up again, each time a dropdown is tapped.

Image

Image

@UX3D-becher
Copy link
Contributor

UX3D-becher commented Feb 5, 2025

The issue is likely an issue in Firefox for iOS, as the error originates in the Firefox extension responsible for autofill of forms:

                       onFocusIn(e)
                        {
                            const t = e.target;
                            if (this.identifyFieldsWhenFocused(t), !this.activeFieldDetail)
                                return;
                            if (!this.activeSection.isValidSection())
                                return;
                            const a = this.transformToFieldNamesWithValues(this.activeSection.fieldDetails);
                            i.FormAutofillUtils.isAddressField(this.activeFieldDetail.fieldName) ? this.callbacks.address.autofill(a) : i.FormAutofillUtils.isCreditCardField(this.activeFieldDetail.fieldName) && (s.CreditCardRecord.normalizeFields(a), this.callbacks.creditCard.autofill(a))
                        }

The error is triggered in the line with if (!this.activeSection.isValidSection()) because this.activeSection evaluates to undefined.

Other lines access this.activeSection with optional chaining, probably this should be done here as well.

Instead of

if (!this.activeSection.isValidSection())
    return;

the following would be my suggested fix:

if (!this.activeSection?.isValidSection())
    return;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants