Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CLI flag to swap between setting build/target rustflags #58

Open
Kobzol opened this issue Jul 23, 2024 · 0 comments
Open

Add a CLI flag to swap between setting build/target rustflags #58

Kobzol opened this issue Jul 23, 2024 · 0 comments

Comments

@Kobzol
Copy link
Owner

Kobzol commented Jul 23, 2024

cargo-pgo currently sets PGO rustflags through target.*.rustflags from Rust 1.63+ (since #57, see #56 for the reasoning). This means that if you have e.g. build.rustflags in your Cargo config file, it will be overridden by the flags set by cargo-pgo.

It might be useful to some users to give them the option to decide whether they want to use the target or the build rustflags. The latter might be useful if the user already has some build.rustflags value set and they do not want to override them.

This was suggested here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant