Skip to content

Commit 555624d

Browse files
committed
Revert "Statically link JSON extension in pybind CI"
This reverts commit 13d6905.
1 parent e401748 commit 555624d

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ jobs:
140140

141141
- name: Update submodules
142142
working-directory: ladybug
143-
run: git submodule update --init --recursive dataset extension
143+
run: git submodule update --init --recursive dataset
144144

145145
- name: Checkout ladybug-python into ladybug/tools/python_api
146146
uses: actions/checkout@v4
@@ -191,7 +191,6 @@ jobs:
191191
GEN: Ninja
192192
CMAKE_C_COMPILER_LAUNCHER: ccache
193193
CMAKE_CXX_COMPILER_LAUNCHER: ccache
194-
EXTRA_CMAKE_FLAGS: -DBUILD_EXTENSIONS=json -DEXTENSION_STATIC_LINK_LIST=json
195194
run: |
196195
make python
197196
cp tools/python_api/src_py/*.py tools/python_api/build/ladybug/

test/test_json.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ def test_to_json_string_param_roundtrip(conn_db_empty: ConnDB) -> None:
1111
"""to_json() with a JSON string parameter should store the parsed object, not a string literal."""
1212
conn, _ = conn_db_empty
1313
conn.execute("""
14+
INSTALL json;
15+
LOAD json;
1416
CREATE NODE TABLE User (id SERIAL PRIMARY KEY, meta JSON);
1517
""")
1618

0 commit comments

Comments
 (0)