[DISCUSSION] Automatically remove duplicates via icontool.py

[x9136]

About this discussion

Duplicates.mp4

Many components in the appfilter.xml have duplicates, so I suggest finding a way to automatically remove them.

I think icontool.py now checks for alphabetical sorting at runtime and fixes it. This will work with duplicates as well. If the lines are identical, leave one. If the components are identical but have different names or svg, somehow inform about it (not sure if the current check in icontool.py works that way).

It will be cleaner.

[SuperDragonXD]

Just so you know, there's a tool called find_duplicates.py to help with this.

They could probably be merged in a new PR, although I currently don't have the time to do this.

[x9136]

@SuperDragonXD The number of duplicates is growing again because many people are manually adding components. Is there any reason why we can't do automatic duplicate removal? The same way automatic sorting happens.

Maybe this should be done automatically before creating a release build. I'm not sure which moment is the best, but clearly that can be given to the computer.

[KTibow]

damn you keep editing your comment

it's not possible for GH Actions to push anymore because they enabled push protection, so it can't be fully automatic
i agree it should be done manually before the next release though
and it's always an option to make the workflow fail if there are unused/duplicate/out-of-order icons

[x9136]

@KTibow You can already delete duplicates manually with a single command. I think it is logical to automate it. One option is the same as with automatic sorting. You run any command, and icontool.py cleans duplicates along with it.

[KTibow]

You can already delete duplicates manually with a single command. I think it is logical to automate it

well - it's not possible to automate it with github actions (because push protection - unless you do some sort of workaround)
to clarify: when i said "it's always an option to make the workflow fail" i meant that it would say "go run icontool on your own device", because even though the action can sort it, it can't push (because push protection)

[x9136]

@KTibow Ok, I understand about GitHub Actions. I'm talking about using icontool.py.

[KTibow]

okay - so what do you mean by automatically then? do you mean that "icontool should be ran to clean up the app filter/icons before the next release"?

[x9136]

@KTibow

python3 icontool.py add /Users/otttis/Desktop/export/fraction_calculator_plus com.digitalchemy.calculator.freefraction/com.digitalchemy.calculator.droidphone.FractionMainActivity "Fraction Calculator Plus"

When I run a command like this, icontool.py not only adds the component, but also sorts the entire list. I think it would be possible to remove duplicates at the same time. For example, before sorting. In this case, manual cleanup of duplicates before release may not be necessary.

[KTibow]

so you think it should run maintenance every time an icon is added?
i doubt most users will be using icontool so running icontool before release will probably still be necessary. plus running maintenance can create merge conflicts.

[KTibow]

also its kinda ironic youre saying this given you introduced duplicates in #1358 (but also kinda makes sense)

[x9136]

@KTibow On the one hand I was using only icontool.py, and on the other hand I was fixing conflicts and making merges with what the previously accepted PRs gave. In all this fuss, duplicates could appear.