-
-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move read_only
posts to its own endpoint, to correctly sort by PostActions
#5505
Comments
The type of action to list posts for (read, like, etc) should be a query parameter |
Why does it matter which table the sort key is from? Anyway the parameters get passed into |
I'm in the process of cleaning up
I've removed / moved a bunch of its functionality to other endpoints anyway, so this is just part of that cleanup.
|
I'd also like to note that this only has to do with ordering the posts by read.
These were confusingly overlapping anyway. |
Comes after #4606 |
Requirements
Is your proposal related to a problem?
As I'm working on cursor pagination in #5429, I'm realizing that its not a good idea to try to include read only posts into
list_posts
, because it uses a sort key from a different table. It usespost_actions_keys::read
to sort, whereas every other one uses thePost
table keys.Similar to
liked_only
, it should be extracted to its own endpoint, with a predictable order, and none of the filters.Describe the solution you'd like.
Create a
post/read/list
endpoint, which uses a properpost_actions::read
sort.Describe alternatives you've considered.
NA
Additional context
#4499
#5429
The text was updated successfully, but these errors were encountered: