Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open issues on popular lemmy apps to prepare for 1.0.0 release #5508

Open
dessalines opened this issue Mar 15, 2025 · 2 comments
Open

Open issues on popular lemmy apps to prepare for 1.0.0 release #5508

dessalines opened this issue Mar 15, 2025 · 2 comments
Milestone

Comments

@dessalines
Copy link
Member

Now that we've fundamentally changed nearly all the data structs, there's no reason to keep an api/v3 in the codebase. Nearly every data structure was changed with #5482 .

As one example:

GET /community/id=? now returns CommunityViews whose data structure is completely changed, regardless of the api structure. Clients thinking they can hit api/v3 and they will receive the same data structures as lemmy 0.19, will be wrong.

Apps should either use backwards-compatible API libraries like MV-GH's for kotlin, or pull down tagged libraries as git submodules (IE lemmy-js-client v0.19, v1.0, etc).

They can which decide which to use based on the lemmy version from GetSite or Nodeinfo.

@dessalines dessalines added this to the 1.0.0 milestone Mar 15, 2025
@Nutomic
Copy link
Member

Nutomic commented Mar 17, 2025

Before doing this we need to be sure that all major Lemmy apps are updated to support the new API. Otherwise instances would stay on 0.19 for a long time to ensure that app users dont get problems. This was part of the reason why lemmy.world stayed on 0.19.3 for so long. In the worst case we may have to keep supporting 0.19 with new updates for a long time. So to avoid that we should make the transition to 1.0 as smooth as possible.

I suggest we follow these steps:

  • Implement all remaining breaking changes
    • post_view cleanup
    • pagination cursors
    • remote site bans
  • Publish 1.0.0-beta.0
  • Put it on voyager.lemmy.ml and https://join-lemmy.org/api/main
  • Open issues for all Lemmy apps to support new API version. These are the most popular apps based on number of requests to lemmy.ml
    • Mlmym
    • Jerboa
    • Sync
    • Mlem
    • Boost
  • Only remove the old api once the new api is supported by most apps/frontends

@dessalines
Copy link
Member Author

Agree, making issues on their repos is a great idea. We'll have to give a lot of time for app devs to prepare for 1.0.0 , as its a completely changed API.

I'll rename this issue to be about that.

@dessalines dessalines changed the title Remove api_routes/v3 , and rename api_routes_v4.rs. Open issues on popular lemmy apps to prepare for 1.0.0 release Mar 17, 2025
dessalines added a commit that referenced this issue Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants