-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Request Type
New input / parameter for an existing workflow
Affected Workflow
Infrastructure (build, dispatch-helm)
Problem / Motivation
The plugin-br-pix-indirect-btg pipeline is opening PRs in the Helm repo (LerianStudio/helm) when RC tags are built (PR #1135). This is because the BTG build workflow explicitly sets helm_dispatch_on_rc: true.
The shared build.yml workflow already has boolean inputs to control this:
helm_dispatch_on_rc(default:false)helm_dispatch_on_beta(default:false)
So the mechanism exists, but repos can opt-in to RC/beta dispatch. The desired behavior is: Helm chart dispatch should only happen on production (main) builds by default, and the BTG plugin repo needs to be updated to remove helm_dispatch_on_rc: true.
Proposed Solution
- Immediate fix: Remove
helm_dispatch_on_rc: truefromplugin-br-pix-indirect-btg/.github/workflows/build.ymlso it uses the default (false). - Audit: Review all repos that call the shared build workflow and verify which ones have
helm_dispatch_on_rcorhelm_dispatch_on_betaset totrue— ensure it's intentional. - Documentation: Add a note in the workflow docs making it clear that Helm dispatch should generally only target production releases (main), unless there's a specific reason for RC/beta dispatch.
Existing Boolean Inputs (reference)
# In build.yml (shared workflow)
helm_dispatch_on_rc:
description: 'Enable Helm dispatch for release-candidate (rc) tags'
type: boolean
default: false
helm_dispatch_on_beta:
description: 'Enable Helm dispatch for beta tags'
type: boolean
default: falseCurrent BTG config (needs fix)
# plugin-br-pix-indirect-btg/.github/workflows/build.yml
enable_helm_dispatch: true
helm_dispatch_on_rc: true # <-- this should be removed/set to falseExample Usage
# Correct: only dispatch on production release tags
enable_helm_dispatch: true
# helm_dispatch_on_rc and helm_dispatch_on_beta default to false — no Helm PRs for pre-release buildsWould This Be a Breaking Change?
No — fully backward compatible
Additional Context
Discussed in #devops-team thread by Guilherme, Bruno, and Bedatty.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request