refactor(http): use strings.Cut for URL sanitization

Replaces the usage of `strings.IndexByte` with the more idiomatic Go
function `strings.Cut`. This function is specifically designed to split
a string into two parts based on a separator, making the code for
redacting URL query parameters clearer and more expressive.

fix(test): remove parallel execution to fix flaky telemetry tests

The telemetry tests in `withTelemetry_test.go` modify shared global
state related to the metrics collector. Running them with `t.Parallel()`
created a race condition, leading to intermittent test failures.

Removing `t.Parallel()` forces these tests to run sequentially,
eliminating the race condition and stabilizing the test suite. A short
sleep was also added to the reset function to ensure the collector has
sufficient time to shut down before the next test starts.

style(test): align struct field values in multi tenant test

Adjusts code formatting in `multi_tenant_test.go` for better
readability by aligning the values in a struct literal. This is a
purely cosmetic change with no functional impact.

Author: fredcamaral

commons/net/http/withTelemetry_helpers.go

@@ -58,8 +58,8 @@ func sanitizeURL(rawURL string) string {
 
 func sanitizeMalformedURL(rawURL string) string {
 	sanitized := sanitizeLogValue(rawURL)
-	if idx := strings.IndexByte(sanitized, '?'); idx >= 0 {
-		return sanitized[:idx] + "?redacted"
+	if before, _, ok := strings.Cut(sanitized, "?"); ok {
+		return before + "?redacted"
 	}
 
 	return sanitized

commons/net/http/withTelemetry_test.go

@@ -550,6 +550,7 @@ func resetMetricsCollectorState() {
 
 	if metricsCollectorStarted && metricsCollectorShutdown != nil {
 		close(metricsCollectorShutdown)
+		time.Sleep(50 * time.Millisecond)
 	}
 
 	metricsCollectorShutdown = nil
@@ -559,7 +560,6 @@ func resetMetricsCollectorState() {
 }
 
 func TestEnsureMetricsCollector_ReturnsErrorWhenMetricsFactoryNil(t *testing.T) {
-	t.Parallel()
 	resetMetricsCollectorState()
 	t.Cleanup(resetMetricsCollectorState)
 
@@ -575,7 +575,6 @@ func TestEnsureMetricsCollector_ReturnsErrorWhenMetricsFactoryNil(t *testing.T)
 }
 
 func TestEnsureMetricsCollector_NoMeterProviderReturnsNil(t *testing.T) {
-	t.Parallel()
 	resetMetricsCollectorState()
 	t.Cleanup(resetMetricsCollectorState)
 
@@ -585,7 +584,6 @@ func TestEnsureMetricsCollector_NoMeterProviderReturnsNil(t *testing.T) {
 }
 
 func TestStopMetricsCollector_AllowsRestart(t *testing.T) {
-	t.Parallel()
 	resetMetricsCollectorState()
 	t.Cleanup(resetMetricsCollectorState)
 

commons/tenant-manager/consumer/multi_tenant_test.go

@@ -889,8 +889,8 @@ func TestMultiTenantConsumer_NewWithZeroConfig(t *testing.T) {
 		{
 			name: "creates_pmClient_when_URL_configured",
 			config: MultiTenantConfig{
-				MultiTenantURL:  "https://tenant-manager:4003",
-				ServiceAPIKey: "test-key",
+				MultiTenantURL: "https://tenant-manager:4003",
+				ServiceAPIKey:  "test-key",
 			},
 			expectedSync:     30 * time.Second,
 			expectedWorkers:  0, // WorkersPerQueue is deprecated, default is 0