-
Notifications
You must be signed in to change notification settings - Fork 5
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
Context
In the v4 unification (PR #336), the default sslmode in buildConnectionString was changed from disable to require.
Where to change
File: commons/tenant-manager/postgres/manager.go
Line 838-839 (on v4.0.0-beta.2):
// Current (v4):
if sslmode == "" {
sslmode = "require" // ← line 839
}
// Should be:
if sslmode == "" {
sslmode = "disable"
}Problem
Teams routinely test locally against PostgreSQL instances without TLS configured. Changing the default to require breaks local development workflows when SSLMode is not explicitly set in the tenant configuration.
While require is the correct default for production, this change should be communicated clearly and potentially handled differently:
Options
- Keep
disableas default and require explicitSSLMode=requirein production configs - Keep
requireas default but document the breaking change prominently in migration guide - Use an environment-aware default (e.g.,
requirein production,disablein development)
Impact
- All services using
buildConnectionStringwithout explicitSSLModein theirPostgreSQLConfig - Local development environments
- CI/CD pipelines with local PostgreSQL
Raised by
Jefferson Rodrigues (CTO) during multi-tenant task force review.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working