Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-native 0.56 dependency broken on Windows, possible upgrade to 0.58? #2

Open
KG204 opened this issue Feb 1, 2019 · 4 comments

Comments

@KG204
Copy link

KG204 commented Feb 1, 2019

I'm trying to integrate a library that uses websocket communication, and I've been running into issues integrating it with LiquidCore-Cli.

Specifically, I get a AccessibilityInfo is not found in Haste module. I think it's related to this bug here:
facebook/react-native#19953
Which seems to have been resolved in earlier and later versions of react-native, just broken on 0.56 on Windows.

@KG204
Copy link
Author

KG204 commented Feb 1, 2019

Specifically referring to init.js script

@ericwlange
Copy link
Member

Metro can be extremely frustrating ...

Upgrading react-native is a little bit more involved than it may seem for two reasons:

  1. There was a major upgrade in metro from 0.56 -> 0.57, so I am pretty sure everything would break by just changing the dependency version
  2. 0.56 was chosen because that was the state-of-the-art version when I created ReactNativeSurface. That project is strictly dependent on 0.56, and upgrading may be a large undertaking that I'm not ready to do yet (it was a lot of work to get it to work in the first place)

I will upgrade eventually, but I am not sure it will work with your timeframe.

I don't have a Windows machine unfortunately so I can't debug this, but have you tried simple/obvious hacks like creating a file called AccessibilityInfo.js and throwing it in node_modules?

@KG204
Copy link
Author

KG204 commented Feb 1, 2019

From the link above, it's not so much about AcessibilityInfo, it's just the first one in a list of dependencies that are tried to resolve.

I will set up a VM with Linux to test 0.56.0 to see if I can use that for bundling,

@ericwlange
Copy link
Member

Others have had success just using webpack instead of metro -- you could see if that works also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants