This repository has been archived by the owner on Oct 13, 2024. It is now read-only.
Some theme music files won't play on Jellyfin Tizen (Jellyfin 10.9.2) #364
Comments
|
Thanks for reporting this. I'm not sure how to fix it at the moment, but I can probably come up with something. Linking this here just for reference, which was a previously similar (but different) issue. #98 Is there a way for you test if the affected files play in an older version of Jellyfin? |
Unfortunately I won't be able to test it with older versions of Jellyfin. I keep only one production instance |
|
Having the same issue here, just started using Jellyfin and installed Themerr These errors appear all around in the logs when downloading the theme songs: The movie was identified to this TMDB url: https://www.themoviedb.org/movie/770 Then when visiting the film page And this on the web browser console: |
|
The files are being downloaded in AAC format. This is the output from a working |
|
@chiva what version of Themerr-jellyfin were you using when the incorrect formats were downloaded? Any chance you once used the very first version of Themerr? As far as I can see this shouldn't be possible: It has been like this since #98 was merged, which was included in the v0.0.2 release (before we switched to calendar versioning). |
|
I'm running Comparing the files with Command returns fine, but this is the exact same command found in the logs that raises an exception: I've deleted all |
|
Btw, the AAC seems to also work, but seems to be a bit hit and miss at this moment, can't find any correlation. |
|
Our plugin saves theme songs to It's probably not wise to use both of these plugins together. The other one is using Plex's theme song database.
My guess is different headers in the files. |
|
Youtube doesn't have If we want to have real using YoutubeExplode;
using YoutubeExplode.Converter;
[...]
public bool SaveMp3(string destination, string videoUrl)
{
try
{
Task.Run(async () =>
{
var youtube = new YoutubeClient();
await youtube.Videos.DownloadAsync(videoUrl, destination);
});
}
catch (Exception e)
{
_logger.LogError(e, "Unable to download {VideoUrl} to {Destination}", videoUrl, destination);
return false;
}
return WaitForFile(destination, 30000);
}I've compiled a test version of the plugin with those changes, and adding the Guess I'm missing the I'm currently testing both plugins, as standing up my Jellyfin instance, so checking features and capabilities of all offerings 😄 |
|
Thanks for digging in to the issue. This plugin is really the only experience I have with C# and Jellyfin as well. Jellyfin has a dev chat on their discord server though, you might get a quick answer there. |
|
That converter requires ffmpeg, does it automatically detect jellyfin's ffmpeg? This test might also need to be adjusted here: Themerr-jellyfin/Jellyfin.Plugin.Themerr.Tests/TestThemerrManager.cs Lines 121 to 129 in 2ccfdea |
|
Yup, needs ffmpeg, I think I can send a PR, will do some more testing |
|
Hey, I've tried multiple times to setup a proper dev environment that allows to debug Jellyfin, using VS Code and Visual Studio both in Mac and Windows, but couldn't get the env setup properly. Will post the idea here: The video needs to be converted, and we can use the We can mostly copy the code from the Add the We will also need to add the dependency into: and https://github.com/LizardByte/Themerr-jellyfin/blob/master/build.yaml I tested it once, but didn't manage to make it work, I think it's because dependencies were not properly compiled and linked into the project. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Describe the Bug
Hello,
After upgrading Jellyfin server to the latest version 10.9.2 and also upgrading Jellyfin Tizen clien and Themerr plugin, some new mp3 theme files like for a movie "Legend (2015)" are not playing at all. Old mp3 files, which were already downloaded are unaffected. Jellyfin Tizen client is reporting error when trying to play theme music that media is not supported.
I analyzed jellyfin logs and found this error: MediaBrowser.Providers.Music.AudioMetadataService: Error in "Probe Provider"
TagLib.CorruptFileException: MPEG audio header not found.
I then analyzed specific mp3 files with this program https://www.codeproject.com/Articles/8295/MPEG-Audio-Frame-Header and confirmed that MPEG audio header is indeed missing ("No frame found within tolerance range" error). Files that Jellyfin Tizen client can play with no problems show correct MPEG Audio Header.
Just a note that these files with missing MPEG audio header are playing with no problems on Windows client
Expected Behavior
No response
Additional Context
No response
The text was updated successfully, but these errors were encountered: