From d944852224070915f6a4ff00d245c49ab037936b Mon Sep 17 00:00:00 2001 From: Nathaniel Hamming Date: Mon, 25 Sep 2023 15:23:14 -0300 Subject: [PATCH 1/3] [COASTAL-1291] plugin identifier is no longer class property (#17) --- AmplitudeServiceKit/AmplitudeService.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/AmplitudeServiceKit/AmplitudeService.swift b/AmplitudeServiceKit/AmplitudeService.swift index 1d38514..3c19bf8 100644 --- a/AmplitudeServiceKit/AmplitudeService.swift +++ b/AmplitudeServiceKit/AmplitudeService.swift @@ -11,7 +11,7 @@ import LoopKit public final class AmplitudeService: Service { - public static let pluginIdentifier = "AmplitudeService" + public let pluginIdentifier = "AmplitudeService" public static let localizedTitle = LocalizedString("Amplitude", comment: "The title of the Amplitude service") From 28516d2fa3292b23cd26baf92c65caac151228c5 Mon Sep 17 00:00:00 2001 From: Nathaniel Hamming Date: Wed, 30 Oct 2024 16:33:37 -0300 Subject: [PATCH 2/3] [PAL-818] service allowDebugFeatures (#19) --- AmplitudeServiceKitUI/AmplitudeService+UI.swift | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/AmplitudeServiceKitUI/AmplitudeService+UI.swift b/AmplitudeServiceKitUI/AmplitudeService+UI.swift index c244599..087e115 100644 --- a/AmplitudeServiceKitUI/AmplitudeService+UI.swift +++ b/AmplitudeServiceKitUI/AmplitudeService+UI.swift @@ -18,12 +18,12 @@ extension AmplitudeService: ServiceUI { UIImage(named: "amplitude_logo", in: Bundle(for: AmplitudeServiceTableViewController.self), compatibleWith: nil)! } - public static func setupViewController(colorPalette: LoopUIColorPalette, pluginHost: PluginHost) -> SetupUIResult + public static func setupViewController(colorPalette: LoopUIColorPalette, pluginHost: PluginHost, allowDebugFeatures: Bool) -> SetupUIResult { return .userInteractionRequired(ServiceNavigationController(rootViewController: AmplitudeServiceTableViewController(service: AmplitudeService(), for: .create))) } - public func settingsViewController(colorPalette: LoopUIColorPalette) -> ServiceViewController + public func settingsViewController(colorPalette: LoopUIColorPalette, allowDebugFeatures: Bool) -> ServiceViewController { return ServiceNavigationController(rootViewController: AmplitudeServiceTableViewController(service: self, for: .update)) } From a8b67c8797d8249051b88023dd7a7040a5e93aab Mon Sep 17 00:00:00 2001 From: Pete Schwamb Date: Thu, 31 Oct 2024 09:26:40 -0500 Subject: [PATCH 3/3] disable module verifier for build performance --- AmplitudeService.xcodeproj/project.pbxproj | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/AmplitudeService.xcodeproj/project.pbxproj b/AmplitudeService.xcodeproj/project.pbxproj index 2a34428..75a6663 100644 --- a/AmplitudeService.xcodeproj/project.pbxproj +++ b/AmplitudeService.xcodeproj/project.pbxproj @@ -615,7 +615,7 @@ DYLIB_COMPATIBILITY_VERSION = 1; DYLIB_CURRENT_VERSION = 1; DYLIB_INSTALL_NAME_BASE = "@rpath"; - ENABLE_MODULE_VERIFIER = YES; + ENABLE_MODULE_VERIFIER = NO; FRAMEWORK_SEARCH_PATHS = "$(inherited)"; INFOPLIST_FILE = AmplitudeServiceKitUI/Info.plist; INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks"; @@ -646,7 +646,7 @@ DYLIB_COMPATIBILITY_VERSION = 1; DYLIB_CURRENT_VERSION = 1; DYLIB_INSTALL_NAME_BASE = "@rpath"; - ENABLE_MODULE_VERIFIER = YES; + ENABLE_MODULE_VERIFIER = NO; FRAMEWORK_SEARCH_PATHS = "$(inherited)"; INFOPLIST_FILE = AmplitudeServiceKitUI/Info.plist; INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks"; @@ -891,7 +891,7 @@ DYLIB_COMPATIBILITY_VERSION = 1; DYLIB_CURRENT_VERSION = 1; DYLIB_INSTALL_NAME_BASE = "@rpath"; - ENABLE_MODULE_VERIFIER = YES; + ENABLE_MODULE_VERIFIER = NO; FRAMEWORK_SEARCH_PATHS = "$(inherited)"; INFOPLIST_FILE = AmplitudeServiceKit/Info.plist; INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks"; @@ -922,7 +922,7 @@ DYLIB_COMPATIBILITY_VERSION = 1; DYLIB_CURRENT_VERSION = 1; DYLIB_INSTALL_NAME_BASE = "@rpath"; - ENABLE_MODULE_VERIFIER = YES; + ENABLE_MODULE_VERIFIER = NO; FRAMEWORK_SEARCH_PATHS = "$(inherited)"; INFOPLIST_FILE = AmplitudeServiceKit/Info.plist; INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";