Code review feedback 1

Author: marcoscano

README.md

@@ -24,7 +24,7 @@ Visit `/admin/config/development/cmc` to configure the module. The following opt
 - **Display errors**: Shows missing cache tags at the top of affected pages
 - **Strict**: Throws exceptions when cache tags are missing (recommended for development)
 
-### Front-end Only
+### Skip Admin Pages
 
 When enabled (default), the module only checks pages using the default theme. When disabled, it also checks admin pages using the admin theme.
 

cmc.links.menu.yml

@@ -3,4 +3,3 @@ cmc.settings:
   description: 'Configure Cacheability Metadata Checker settings.'
   parent: system.admin_config_development
   route_name: cmc.settings
-  weight: 100

config/install/cmc.settings.yml

@@ -1,3 +1,3 @@
 operation_mode: 'disabled'
-front_end_only: true
+skip_admin: true
 skip_urls: []

config/schema/cmc.schema.yml

@@ -10,9 +10,9 @@ cmc.settings:
           - disabled
           - errors
           - strict
-    front_end_only:
+    skip_admin:
       type: boolean
-      label: 'Check front-end only'
+      label: 'Skip admin pages'
     skip_urls:
       label: URLs to be skipped
       type: sequence

src/EventSubscriber/LoadedEntitySubscriber.php

@@ -111,8 +111,8 @@ public function onResponse(ResponseEvent $responseEvent) {
 
     // Skip checking if this is an admin page and the config is set to only
     // check front-end pages.
-    $only_front_end = $this->config->get('front_end_only') ?? TRUE;
-    if ($only_front_end) {
+    $skip_admin = $this->config->get('skip_admin') ?? TRUE;
+    if ($skip_admin) {
       $active_theme = $this->themeManager->getActiveTheme()->getName();
       $admin_theme = $this->configFactory->get('system.theme')->get('admin');
       if ($active_theme === $admin_theme) {
@@ -136,7 +136,7 @@ public function onResponse(ResponseEvent $responseEvent) {
     // Never fail hard on our own config page to avoid smart users locking
     // themselves out of the house.
     if ($operation_mode === 'strict' &&
-      !$only_front_end &&
+      !$skip_admin &&
       $this->routeMatch->getRouteName() === 'cmc.settings') {
       return;
     }

src/Form/CmcSettingsForm.php

@@ -5,6 +5,7 @@
 namespace Drupal\cmc\Form;
 
 use Drupal\Core\Form\ConfigFormBase;
+use Drupal\Core\Form\ConfigTarget;
 use Drupal\Core\Form\FormStateInterface;
 
 /**
@@ -41,40 +42,32 @@ public function buildForm(array $form, FormStateInterface $form_state) {
         'errors' => $this->t('Display errors'),
         'strict' => $this->t('Strict'),
       ],
-      '#default_value' => $config->get('operation_mode'),
+      '#config_target' => 'cmc.settings:operation_mode',
     ];
 
-    $form['front_end_only'] = [
+    $form['skip_admin'] = [
       '#type' => 'checkbox',
-      '#title' => $this->t('Check front-end only'),
+      '#title' => $this->t('Skip admin pages'),
       '#description' => $this->t('When enabled, cache tags will only be checked on pages using the default theme (front-end). When disabled, admin pages will be checked as well.'),
-      '#default_value' => $config->get('front_end_only'),
+      '#config_target' => 'cmc.settings:skip_admin',
     ];
 
     $form['skip_urls'] = [
       '#type' => 'textarea',
       '#title' => $this->t('Skip URLs'),
       '#description' => $this->t("A comma or new-line separated list of relative URLs that should not be checked."),
       '#default_value' => implode("\r\n", $config->get('skip_urls')),
+      '#config_target' => new ConfigTarget(
+        'cmc.settings',
+        'skip_urls',
+        // Converts config value to a form value.
+        fn($value) => implode("\r\n", $value),
+        // Converts form value to a config value.
+        fn($value) => array_map('trim', explode("\r\n", trim($value))),
+      ),
     ];
 
     return parent::buildForm($form, $form_state);
   }
 
-  /**
-   * {@inheritdoc}
-   */
-  public function submitForm(array &$form, FormStateInterface $form_state) {
-    $skip_urls = preg_replace('/[\s, ]/', ',', $form_state->getValue('skip_urls'));
-    $skip_urls = array_values(array_filter(explode(',', $skip_urls)));
-
-    $this->config('cmc.settings')
-      ->set('operation_mode', $form_state->getValue('operation_mode'))
-      ->set('front_end_only', $form_state->getValue('front_end_only'))
-      ->set('skip_urls', $skip_urls)
-      ->save();
-
-    parent::submitForm($form, $form_state);
-  }
-
 }