Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Pantheon GitHub Actions available even without PantheonReviewApps Workflow #499

Open
quicksketch opened this issue Mar 28, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@quicksketch
Copy link
Member

I'm setting up a new project that uses Tugboat + Pantheon. I'd like to be able to deploy to Pantheon using Drainpipe's available GitHub action scripts, but I don't want to use PantheonReviewApps.yml since it is redundant with Tugboat.

I found out that if I enable Pantheon integration with:

        "drainpipe": {
            "github": ["PantheonReviewApps"]
        }

It adds the .github/actions/drainpipe/pantheon directory with the associate Pantheon actions. But it also adds the PantheonReviewApps.yml. If I try deleting PantheonReviewApps.yml, it is reinstalled on every composer install, and I remove the PantheonReviewApps from composer.json, then it also deletes the .github/actions/drainpipe/pantheon actions directory.

I'd like to be able to keep the actions in place so I can use them for deployment to the dev environment (not a multidev). You'd think I'd be able to just git commit the actions, but Drainpipe actually forcibly removes the entire .github/actions/drainpipe directory on every composer install, which causes the actions to be removed when running ddev task build.

For now what I've done is leave PantheonReviewApps in place in my composer.json, then I disable the workflow manually in the GitHub UI:

image

But what I'd like to see is the ability to just have the actions and not the PantheonReviewApps workflow. Maybe a new key could be introduced to just include the actions like this:

        "drainpipe": {
            "github": ["PantheonActions"]
        }
@quicksketch quicksketch added the enhancement New feature or request label Mar 28, 2024
@quicksketch quicksketch changed the title Make Pantheon GitHub Actions available even without PantheonReviewApps Make Pantheon GitHub Actions available even without PantheonReviewApps Workflow Mar 28, 2024
@mrdavidburns
Copy link
Member

@quicksketch have you tried just using "Pantheon"? Not sure if this still works as it looks to be an artifact from resolving an old merge conflict. Also not sure if this only applies to GitLab. https://github.com/Lullabot/drainpipe?tab=readme-ov-file#pantheon-2

"extra": {
    "drainpipe": {
        "gitlab": ["Pantheon"]
    }
}

@quicksketch
Copy link
Member Author

quicksketch commented Mar 28, 2024

@mrdavidburns Adding the same thing for GitHub has no effect at all.

        "drainpipe": {
            "github": ["Pantheon"]
        }

It does work on GitLab.

This seems to overlap a bit with #500, where general Pantheon support was broken. The default pantheon.yml file isn't getting created either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants