Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid composer lock diff action if composer.lock hasn't changed #677

Open
beto-aveiga opened this issue Sep 3, 2024 · 2 comments · May be fixed by #780
Open

Avoid composer lock diff action if composer.lock hasn't changed #677

beto-aveiga opened this issue Sep 3, 2024 · 2 comments · May be fixed by #780
Assignees

Comments

@beto-aveiga
Copy link
Collaborator

Composer lock diff action takes about ~3 minutes on a minimal site.
There is no need to run this workflow if there are no composer changes, or we could avoid running it for 3 minutes (depending on the site, this may vary).
We could skip it in the mentioned scenario and use less than 1 minute.

@deviantintegral
Copy link
Member

Good call. I think we can do this with a path filter in GitHub at least: https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#onpushpull_requestpull_request_targetpathspaths-ignore

@alexanderpatriciop
Copy link
Collaborator

@deviantintegral Good suggestion, I tested it on a test project and it works as desired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants