Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some form of 2FA #6

Closed
Tigger2014 opened this issue Jun 15, 2018 · 5 comments
Closed

Add some form of 2FA #6

Tigger2014 opened this issue Jun 15, 2018 · 5 comments

Comments

@Tigger2014
Copy link

Tigger2014 commented Jun 15, 2018

Hi there I have added a very rough form of googles 2fa to this and wondered in this was something you might like to tidy up and add yourself.

Tigger2014@45c4ab9

@askz
Copy link

askz commented Dec 5, 2018

Hi @Tigger2014
I'm very interested about this feature.
Is your implementation working right now ?
@Luzifer what are you thoughts about this? Could this be integrated here?
Thanks.

@Luzifer
Copy link
Owner

Luzifer commented Dec 5, 2018

@askz There is a yet unfinished implementation in PR #10 - It currently lacks any MFA provider and therefore is fully untested. I plan to continue work on that PR within my end-of-year vacation starting next week. So I hope to have MFA implemented until end of this year.

@Tigger2014
Copy link
Author

@askz my implementation does work but i would recommend waiting until @Luzifer has finished his implementation as it looks to be much more robust. I can't promise mine is secure, feel free to give it a try if you wish though, I'm willing to answer any questions if i can

@askz
Copy link

askz commented Dec 5, 2018

Thank you guys for the fast answers!!

Will check around both implementations and tell you what!

@Luzifer
Copy link
Owner

Luzifer commented Dec 24, 2018

MFA support has landed in v0.12.0!

@Luzifer Luzifer closed this as completed Dec 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants