FIX: another missing if() protecting access to uninitialized js data

jlblancoc · jlblancoc · commit 4f202ffaaa7e · 2025-02-05T10:25:26.000+01:00
diff --git a/modules/simulator/src/VehicleDynamics/VehicleAckermann_ControllerTwistFrontSteerPID.cpp b/modules/simulator/src/VehicleDynamics/VehicleAckermann_ControllerTwistFrontSteerPID.cpp
@@ -170,7 +170,7 @@ void DynamicsAckermann::ControllerTwistFrontSteerPID::teleop_interface(
 
 	out.append_gui_lines += "[Controller=" + std::string(class_name()) + "]";
 
-	if (in.js)
+	if (in.js && in.js->axes.size() >= 2)
 	{
 		const auto& js = in.js.value();
 		const float js_x = js.axes[0];

Original file line number	Diff line number	Diff line change
`@@ -170,7 +170,7 @@ void DynamicsAckermann::ControllerTwistFrontSteerPID::teleop_interface(`
`170`	`170`
`171`	`171`	`out.append_gui_lines += "[Controller=" + std::string(class_name()) + "]";`
`172`	`172`
`173`		`- if (in.js)`
	`173`	`+ if (in.js && in.js->axes.size() >= 2)`
`174`	`174`	`{`
`175`	`175`	`const auto& js = in.js.value();`
`176`	`176`	`const float js_x = js.axes[0];`