Skip to content
This repository was archived by the owner on Mar 26, 2023. It is now read-only.
This repository was archived by the owner on Mar 26, 2023. It is now read-only.

Nice to fix indexing error message if for dynamic inst vars. #43

@pbm

Description

@pbm

The current indexing implementation does not support indexing of dynamic instance variables. If you try to index on a dynamic instance variable, the error message is misleading:

$ maglev-ruby -MallIvsDynamic src/test/IdentitySetIndexingTest.rb 
Loaded suite src/test/IdentitySetIndexingTest
Started
EEEE.E
Finished in 0.10773199999999999 seconds.

  1) Error:
test_mixed_class_sets(TestBasicEqualityIndexSupport):
RuntimeError: The object anId does not have an instance variable with the given name #'@id'
    /Users/pmclain/GemStone/snapshots/current/lib/ruby/1.8/test/unit/error.rb:46:in `long_display'
    /Users/pmclain/GemStone/snapshots/current/lib/ruby/1.8/test/unit/ui/console/testrunner.rb:86:in `finished'
    /Users/pmclain/GemStone/snapshots/current/lib/ruby/1.8/test/unit/ui/console/testrunner.rb:84:in `each_with_index'
    /Users/pmclain/GemStone/snapshots/current/lib/ruby/1.8/test/unit/ui/console/testrunner.rb:84:in `finished'

It would be nice if we could change the error message to indicate that @id is a dynamic instance variable.

Trac Info

  • Ticket: 792
  • Created: 2010-09-28T12:26:04-0700
  • Reporter: pmclain

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions