Windows-specific fixes discovered by CI/CD

Author: Enmk

clickhouse/base/compressed.cpp

@@ -142,7 +142,7 @@ void CompressedOutput::Compress(const void * data, size_t len) {
             (const char*)data,
             (char*)compressed_buffer_.data() + HEADER_SIZE,
             len,
-            compressed_buffer_.size() - HEADER_SIZE);
+            static_cast<int>(compressed_buffer_.size() - HEADER_SIZE));
     if (compressed_size <= 0)
         throw std::runtime_error("Failed to compress chunk of " + std::to_string(len) + " bytes, "
                 "LZ4 error: " + std::to_string(compressed_size));
@@ -164,7 +164,7 @@ void CompressedOutput::Compress(const void * data, size_t len) {
 }
 
 void CompressedOutput::PreallocateCompressBuffer(size_t input_size) {
-    const auto estimated_compressed_buffer_size = LZ4_compressBound(input_size);
+    const auto estimated_compressed_buffer_size = LZ4_compressBound(static_cast<int>(input_size));
     if (estimated_compressed_buffer_size <= 0)
         throw std::runtime_error("Failed to estimate compressed buffer size, LZ4 error: " + std::to_string(estimated_compressed_buffer_size));
 

clickhouse/client.cpp

@@ -328,9 +328,10 @@ void Client::Impl::ResetConnection() {
         socket = std::make_unique<Socket>(address);
 
     if (options_.tcp_keepalive) {
-        socket->SetTcpKeepAlive(options_.tcp_keepalive_idle.count(),
-                          options_.tcp_keepalive_intvl.count(),
-                          options_.tcp_keepalive_cnt);
+        socket->SetTcpKeepAlive(
+                static_cast<int>(options_.tcp_keepalive_idle.count()),
+                static_cast<int>(options_.tcp_keepalive_intvl.count()),
+                static_cast<int>(options_.tcp_keepalive_cnt));
     }
     if (options_.tcp_nodelay) {
         socket->SetTcpNoDelay(options_.tcp_nodelay);

clickhouse/columns/decimal.cpp

@@ -134,7 +134,7 @@ void ColumnDecimal::Append(const std::string& value) {
     bool sign = true;
     bool has_dot = false;
 
-    int zeros = 0;
+    size_t zeros = 0;
 
     while (c != end) {
         if (*c == '-') {

ut/readonly_client_test.cpp

@@ -18,6 +18,8 @@ void ReadonlyClientTest::TearDown() {
     client_.reset();
 }
 
+// Sometimes gtest fails to detect that this test is instantiated elsewhere, suppress the error explicitly.
+GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST(ReadonlyClientTest);
 TEST_P(ReadonlyClientTest, Select) {
 
     const auto & queries = std::get<1>(GetParam());