Problem
kinetic._parse_graph() parses files in isolation via LogosParser but is no longer called — scan, export, and visualize use LogseqGraph.load_directory / iter_canonical_pages() instead.
Dead code violates SRP (KINETIC still carries two graph-loading strategies) and confuses contributors reading kinetic.py.
Clean Architecture lens
| Aspect |
Assessment |
| Ring |
Frameworks & Drivers (kinetic.py CLI) |
| Dependency rule |
CLI should call one graph use-case entry (LogseqGraph.load_directory) |
| Uncle Bob |
Boy Scout Rule — remove misleading paths |
Proposed Solution
- Delete
_parse_graph if truly unused (grep confirms only definition remains)
- If Progress-bar-only parsing is still needed, document why and add a single wrapper used by all commands
Files
src/logseq_matryca_parser/kinetic.py
Definition of Done
- No dead graph-load helper
make all passes
Problem
kinetic._parse_graph()parses files in isolation viaLogosParserbut is no longer called —scan,export, andvisualizeuseLogseqGraph.load_directory/iter_canonical_pages()instead.Dead code violates SRP (KINETIC still carries two graph-loading strategies) and confuses contributors reading
kinetic.py.Clean Architecture lens
kinetic.pyCLI)LogseqGraph.load_directory)Proposed Solution
_parse_graphif truly unused (grep confirms only definition remains)Files
src/logseq_matryca_parser/kinetic.pyDefinition of Done
make allpasses