MDEV-36800 Assertion `thd_arg->in_multi_stmt_transaction_mode() at rolling back..

XA in XA_ROLLBACK_ONLY state.

The assert was too strict having not anticipated to face a XA-PREPARE
ending in rolling back.
That's a correct behaviour of read-only disconnecting XA.

Fixed to relax the assert.

Author: emoonrain

mysql-test/suite/binlog/r/mdev-32830_qa_tests.result

@@ -1,3 +1,4 @@
+set @@session.binlog_format=row;
 CREATE TABLE t (c INT) ENGINE=InnoDB;
 XA START 'a';
 SAVEPOINT s;
@@ -20,4 +21,17 @@ master-bin.000001	#	Query	#	#	ROLLBACK
 Cleanup
 DROP TEMPORARY TABLE t;
 DROP TABLE t;
+set @@session.binlog_format=statement;
+CREATE TABLE t1 (c CHAR(1),c2 CHAR(1)) ENGINE=MyISAM;
+CREATE TEMPORARY TABLE t (a INT) ENGINE=InnoDB SELECT+1 a;
+XA START 'a';
+INSERT t SELECT+1 seq_1_to_1;
+SET pseudo_slave_mode=1;
+INSERT INTO t1 (c) VALUES (1);
+XA END 'a';
+XA PREPARE 'a';
+# cleanup
+XA ROLLBACK 'a';
+DROP TABLE t;
+DROP TABLE t1;
 End of tests

mysql-test/suite/binlog/t/mdev-32830_qa_tests.test

@@ -1,6 +1,9 @@
---source include/have_binlog_format_row.inc
+--source include/have_log_bin.inc
 --source include/have_innodb.inc
 
+# MDEV-36804
+set @@session.binlog_format=row;
+
 CREATE TABLE t (c INT) ENGINE=InnoDB;
 XA START 'a';
 SAVEPOINT s;
@@ -21,4 +24,24 @@ source include/show_binlog_events.inc;
 DROP TEMPORARY TABLE t;
 DROP TABLE t;
 
+# MDEV-36800
+set @@session.binlog_format=statement;
+
+CREATE TABLE t1 (c CHAR(1),c2 CHAR(1)) ENGINE=MyISAM;
+CREATE TEMPORARY TABLE t (a INT) ENGINE=InnoDB SELECT+1 a;
+XA START 'a';
+INSERT t SELECT+1 seq_1_to_1;
+SET pseudo_slave_mode=1;
+INSERT INTO t1 (c) VALUES (1);
+XA END 'a';
+XA PREPARE 'a';
+
+--echo # cleanup
+--error ER_XAER_NOTA
+XA ROLLBACK 'a';
+--error ER_BAD_TABLE_ERROR
+DROP TABLE t;
+DROP TABLE t1;
+
+
 --echo End of tests

sql/log_event_server.cc

@@ -2907,7 +2907,9 @@ Gtid_log_event::Gtid_log_event(THD *thd_arg, uint64 seq_no_arg,
     }
     else if (thd->lex->sql_command == SQLCOM_XA_PREPARE)
     {
-      DBUG_ASSERT(thd_arg->in_multi_stmt_transaction_mode());
+      /* destined to rollback xa has already reset the multi-stmt feature */
+      DBUG_ASSERT(thd->in_multi_stmt_transaction_mode() ||
+                  xid_state.get_state_code() == XA_ROLLBACK_ONLY);
 
       uint8 count= ha_count_rw_2pc(thd_arg, true);
       extra_engines= count > 1 ? 0 : UCHAR_MAX;