Fix token validation error by adding transformation layer for WebAssembly response (#22)

* Initial plan

* Add test to reproduce source map parsing issue

Co-authored-by: MasonChow <12403684+MasonChow@users.noreply.github.com>

* Fix token validation error by adding transformation layer for WebAssembly response

Co-authored-by: MasonChow <12403684+MasonChow@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: MasonChow <12403684+MasonChow@users.noreply.github.com>
Co-authored-by: MasonChow <masonchat@foxmail.com>

Author: Copilot

src/external/docs/guide.xml

@@ -55,13 +55,35 @@ src/
   server.ts
 tests/
   client.test.ts
+  issue-21-fix.test.ts
   memoryCacheManager.test.ts
+  sourcemap-issue.test.ts
+  sourcemap-local.test.ts
 README.md
 </directory_structure>
 
 <files>
 This section contains the contents of the repository's files.
 
+<file path="tests/issue-21-fix.test.ts">
+import { describe, it, expect } from 'vitest';
+import Parser from '../src/parser.js';
+import fs from 'fs/promises';
+import path from 'path';
+⋮----
+// Read the local source map file mentioned in the issue
+⋮----
+// Test the exact stack traces from the issue
+⋮----
+// Verify the token structure is correct
+⋮----
+// Verify sourceCode array contains SourceCode objects with correct structure
+⋮----
+// Use the local source map file for consistent results
+⋮----
+// For file:// URLs, we expect fetch to fail, which is OK
+</file>
+
 <file path="src/types/source_map_parser_node.d.ts">
 export function init(): Promise<void>;
 export function generate_token_by_single_stack(
@@ -355,6 +377,12 @@ private validateToken(token: any): asserts token is Token
 ⋮----
 // Validate each source code entry
 ⋮----
+/**
+   * Transforms the raw response from WebAssembly module to match the expected Token interface
+   * @param rawToken - The raw token object from WebAssembly (uses snake_case)
+   * @returns Transformed token object matching the Token interface (uses camelCase)
+   */
+private transformToken(rawToken: any): Token
 /**
    * Retrieves the source token for a given line and column in the source map.
    * 
@@ -366,6 +394,8 @@ private validateToken(token: any): asserts token is Token
    */
 public async getSourceToken(line: number, column: number, sourceMap: string): Promise<Token>
 ⋮----
+// Transform the raw token to match the expected interface
+⋮----
 // Validate the token structure
 </file>
 
@@ -401,6 +431,13 @@ cache.set('b', bufB, 'etag-b'); // should evict 'a'
 const bigBuf = Buffer.alloc(2 * 1024 * 1024, 1); // 2MB
 </file>
 
+
+<file path="tests/sourcemap-issue.test.ts">
+import { describe, it, expect } from 'vitest';
+import Parser from '../src/parser.js';
+// If it fails due to network issues, that's OK for now
+</file>
+
 <file path="README.md">
 [![MseeP.ai Security Assessment Badge](https://mseep.net/pr/masonchow-source-map-parser-mcp-badge.png)](https://mseep.ai/app/masonchow-source-map-parser-mcp)
 

src/parser.ts

@@ -260,6 +260,24 @@ class Parser {
     }
   }
 
+  /**
+   * Transforms the raw response from WebAssembly module to match the expected Token interface
+   * @param rawToken - The raw token object from WebAssembly (uses snake_case)
+   * @returns Transformed token object matching the Token interface (uses camelCase)
+   */
+  private transformToken(rawToken: any): Token {
+    return {
+      line: rawToken.line,
+      column: rawToken.column,
+      src: rawToken.src,
+      sourceCode: rawToken.source_code?.map((sourceCode: any) => ({
+        line: sourceCode.line,
+        isStackLine: sourceCode.is_stack_line,
+        raw: sourceCode.raw
+      })) || []
+    };
+  }
+
   /**
    * Retrieves the source token for a given line and column in the source map.
    * 
@@ -274,7 +292,10 @@ class Parser {
 
     try {
       const res = sourceMapParser.generate_token_by_single_stack(line, column, sourceMap, this.contextOffsetLine);
-      const token = JSON.parse(res);
+      const rawToken = JSON.parse(res);
+      
+      // Transform the raw token to match the expected interface
+      const token = this.transformToken(rawToken);
 
       // Validate the token structure
       this.validateToken(token);

tests/issue-21-fix.test.ts

@@ -0,0 +1,104 @@
+import { describe, it, expect } from 'vitest';
+import Parser from '../src/parser.js';
+import fs from 'fs/promises';
+import path from 'path';
+
+describe('Issue #21 - Token validation fix', () => {
+  it('should correctly parse multiple stack traces from the issue report', async () => {
+    const parser = new Parser({ contextOffsetLine: 1 });
+    
+    // Read the local source map file mentioned in the issue
+    const sourceMapPath = path.join(process.cwd(), 'example', 'special', 'foo.js.map');
+    const sourceMapContent = await fs.readFile(sourceMapPath, 'utf-8');
+    
+    // Test the exact stack traces from the issue
+    const testCases = [
+      { line: 49, column: 34832, description: 'Main error location' },
+      { line: 48, column: 83322, description: 'ka function call' },
+      { line: 48, column: 98013, description: 'Vs function call (1)' },
+      { line: 48, column: 97897, description: 'Et function call (1)' },
+      { line: 48, column: 98749, description: 'Vs function call (2)' },
+      { line: 48, column: 97897, description: 'Et function call (2)' },
+      { line: 48, column: 98059, description: 'Vs function call (3)' },
+      { line: 48, column: 110550, description: 'sv function call' },
+      { line: 48, column: 107925, description: 'Anonymous call' },
+      { line: 25, column: 1635, description: 'MessagePort.Ot call' }
+    ];
+    
+    console.log('Testing all stack traces from the original issue...');
+    
+    for (const testCase of testCases) {
+      try {
+        const token = await parser.getSourceToken(testCase.line, testCase.column, sourceMapContent);
+        
+        // Verify the token structure is correct
+        expect(token).toBeDefined();
+        expect(typeof token.line).toBe('number');
+        expect(typeof token.column).toBe('number');
+        expect(typeof token.src).toBe('string');
+        expect(Array.isArray(token.sourceCode)).toBe(true);
+        
+        // Verify sourceCode array contains SourceCode objects with correct structure
+        for (const sourceCode of token.sourceCode) {
+          expect(typeof sourceCode.line).toBe('number');
+          expect(typeof sourceCode.isStackLine).toBe('boolean');
+          expect(typeof sourceCode.raw).toBe('string');
+        }
+        
+        console.log(`✅ ${testCase.description} (${testCase.line}:${testCase.column}) - Success`);
+        console.log(`   → Mapped to: ${token.src}:${token.line}:${token.column}`);
+        
+      } catch (error) {
+        console.error(`❌ ${testCase.description} (${testCase.line}:${testCase.column}) - Failed:`, error.message);
+        throw error;
+      }
+    }
+    
+    console.log('🎉 All test cases passed! The issue has been resolved.');
+  });
+  
+  it('should handle batch parsing correctly', async () => {
+    const parser = new Parser({ contextOffsetLine: 1 });
+    
+    // Use the local source map file for consistent results
+    const sourceMapPath = path.join(process.cwd(), 'example', 'special', 'foo.js.map');
+    const sourceMapUrl = `file://${sourceMapPath}`;
+    
+    const stacks = [
+      {
+        line: 49,
+        column: 34832,
+        sourceMapUrl: sourceMapUrl
+      },
+      {
+        line: 48,
+        column: 83322,
+        sourceMapUrl: sourceMapUrl
+      }
+    ];
+    
+    try {
+      const result = await parser.batchParseStack(stacks);
+      
+      expect(result).toBeDefined();
+      expect(Array.isArray(result)).toBe(true);
+      expect(result.length).toBe(2);
+      
+      for (const res of result) {
+        if (res.success) {
+          expect(res.token).toBeDefined();
+          expect(Array.isArray(res.token.sourceCode)).toBe(true);
+          console.log(`✅ Batch parsing success: ${res.token.src}:${res.token.line}:${res.token.column}`);
+        } else {
+          console.log(`ℹ️ Batch parsing failed (expected for file:// URLs):`, res.error?.message);
+          // For file:// URLs, we expect fetch to fail, which is OK
+          expect(res.error).toBeDefined();
+        }
+      }
+      
+    } catch (error) {
+      console.error('Batch parsing test error:', error);
+      throw error;
+    }
+  });
+});