Skip to content

Commit bfdfe56

Browse files
sofyenneexo-swf
authored andcommitted
feat: Review UX of advanced settings options for the news list - MEED-10327 - Meeds-io/MIPs#247 (#704)
1 parent da58b94 commit bfdfe56

File tree

3 files changed

+44
-33
lines changed

3 files changed

+44
-33
lines changed

content-service/src/main/resources/locale/portlet/news/News_en.properties

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -235,6 +235,7 @@ news.list.settings.newsTargets.description=Display articles published toward thi
235235
news.list.settings.viewTemplate.description=Customize the display of this news block
236236
news.list.settings.information=This news block displays published articles. As a publisher, you can tailor how it looks using the settings below.
237237
news.list.settings.translation.header=Translate header name
238+
news.list.settings.drawer.editDisplaySettings=Edit Display Settings
238239

239240
newsTargets.settings.title=News Publication Targets
240241
newsTargets.settings.button.addTarget=Add a target

content-webapp/src/main/webapp/vue-app/news-list-view/components/settings/NewsListSelector.vue

Lines changed: 28 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -62,31 +62,34 @@ Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
6262
v-for="(article, index) in selectedArticles"
6363
:class="index === lastSelectedIndex && 'mb-2' || 'mb-n2'"
6464
:key="article.id">
65-
<v-list-item-content class="pa-0">
66-
<v-list-item-title class="text-truncate pa-0 ma-0">
67-
{{ article.title }}
68-
</v-list-item-title>
69-
</v-list-item-content>
70-
<v-btn
71-
v-if="index !== 0"
72-
icon
73-
small
74-
@click="moveUp(index)">
75-
<v-icon small>fa-arrow-up</v-icon>
76-
</v-btn>
77-
<v-btn
78-
v-if="index !== lastSelectedIndex"
79-
icon
80-
small
81-
@click="moveDown(index)">
82-
<v-icon small>fa-arrow-down</v-icon>
83-
</v-btn>
84-
<v-icon
85-
small
86-
class="ml-2 red--text"
87-
@click="remove(article)">
88-
fa-trash
89-
</v-icon>
65+
<v-list-item-title class="text-truncate pa-0 ma-0">
66+
{{ article.title }}
67+
</v-list-item-title>
68+
<v-list-item-action class="flex-row ma-0 align-center justify-end">
69+
<v-btn
70+
v-if="index !== 0"
71+
icon
72+
small
73+
@click="moveUp(index)">
74+
<v-icon small>fa-arrow-up</v-icon>
75+
</v-btn>
76+
<v-btn
77+
v-if="index !== lastSelectedIndex"
78+
icon
79+
small
80+
@click="moveDown(index)">
81+
<v-icon small>fa-arrow-down</v-icon>
82+
</v-btn>
83+
<v-btn
84+
icon
85+
small
86+
class="ml-2"
87+
@click="remove(article)">
88+
<v-icon class="error-color" small>
89+
fa-trash
90+
</v-icon>
91+
</v-btn>
92+
</v-list-item-action>
9093
</v-list-item>
9194
</v-list>
9295
</v-flex>

content-webapp/src/main/webapp/vue-app/news-list-view/components/settings/NewsSettingsDrawer.vue

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -108,14 +108,21 @@
108108
@see-all-url="setSeeAllUrl"
109109
@selected-option="selectedOption" />
110110
</form>
111-
<div class="d-flex flex-row mt-4 mx-8 justify-end advancedSettings">
112-
<span
113-
v-if="!showAdvancedSettings"
114-
class="primary--text text-decoration-underline clickable"
115-
@click="showAdvancedSettings = !showAdvancedSettings">
116-
{{ $t('news.list.settings.drawer.advancedSettings') }}
117-
</span>
118-
</div>
111+
<v-list dense v-if="!showAdvancedSettings">
112+
<v-list-item>
113+
<v-list-item-title>
114+
{{ $t('news.list.settings.drawer.editDisplaySettings') }}
115+
</v-list-item-title>
116+
<v-list-item-action class="align-center justify-end">
117+
<v-btn
118+
icon
119+
small
120+
@click="showAdvancedSettings = !showAdvancedSettings">
121+
<v-icon small>fa-edit</v-icon>
122+
</v-btn>
123+
</v-list-item-action>
124+
</v-list-item>
125+
</v-list>
119126
</template>
120127
<template slot="footer">
121128
<div class="d-flex">

0 commit comments

Comments
 (0)