You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the label for pods that allows them to be skipped during drain, is configured in the common driver upgrade library.
This approach is unclear since it's not part of the explicit public API.
We can configure our own such label by including one more expression into the podSelector in the drain spec. This logic for handling drain skip should also be removed from the https://github.com/NVIDIA/k8s-operator-libs
The text was updated successfully, but these errors were encountered:
Q: "We can configure our own such label" - does this mean there would B redundancy w/ the CommonUpgrade lib, or should there B a corresponding fix to remove the logic from that lib?
A: There will be redundancy. I think the best course of action would be to apply the change to net-op, notify the gpu op team and drop when/if they apply the same change to their code
Currently the label for pods that allows them to be skipped during drain, is configured in the common driver upgrade library.
This approach is unclear since it's not part of the explicit public API.
We can configure our own such label by including one more expression into the podSelector in the drain spec. This logic for handling drain skip should also be removed from the https://github.com/NVIDIA/k8s-operator-libs
The text was updated successfully, but these errors were encountered: