|
2 | 2 |
|
3 | 3 | from unittest.mock import MagicMock |
4 | 4 |
|
| 5 | +import numpy as np |
5 | 6 | import pytest |
6 | 7 |
|
7 | | -from memos.memories.textual.item import TextualMemoryItem, TreeNodeTextualMemoryMetadata |
| 8 | +from memos.memories.textual.item import ( |
| 9 | + SearchedTreeNodeTextualMemoryMetadata, |
| 10 | + TextualMemoryItem, |
| 11 | + TreeNodeTextualMemoryMetadata, |
| 12 | +) |
8 | 13 | from memos.memories.textual.tree_text_memory.retrieve.searcher import Searcher |
9 | 14 | from memos.reranker.base import BaseReranker |
10 | 15 |
|
@@ -168,3 +173,131 @@ def test_deduplicate_rawfile_results_uses_knowledge_summary_ids(mock_searcher): |
168 | 173 |
|
169 | 174 | assert result == [raw_file] |
170 | 175 | mock_searcher.graph_store.get_edges.assert_not_called() |
| 176 | + |
| 177 | + |
| 178 | +def make_searched_item(content: str, score: float, relativity: float = 0.5): |
| 179 | + """Build a Searched-type candidate as produced by vector/fulltext recall.""" |
| 180 | + return ( |
| 181 | + TextualMemoryItem( |
| 182 | + id=str(uuid.uuid4()), |
| 183 | + memory=content, |
| 184 | + metadata=SearchedTreeNodeTextualMemoryMetadata( |
| 185 | + memory_type="LongTermMemory", |
| 186 | + embedding=[0.1] * 5, |
| 187 | + usage=[], |
| 188 | + sources=[{"type": "chat", "role": "user", "content": "context"}], |
| 189 | + relativity=relativity, |
| 190 | + ), |
| 191 | + ), |
| 192 | + score, |
| 193 | + ) |
| 194 | + |
| 195 | + |
| 196 | +def rebuild_like_before(item: TextualMemoryItem, score: float) -> TextualMemoryItem: |
| 197 | + """Reference implementation of the pre-optimization dump-and-rebuild behavior.""" |
| 198 | + meta_data = item.metadata.model_dump() |
| 199 | + meta_data["relativity"] = score |
| 200 | + return TextualMemoryItem( |
| 201 | + id=item.id, |
| 202 | + memory=item.memory, |
| 203 | + metadata=SearchedTreeNodeTextualMemoryMetadata(**meta_data), |
| 204 | + ) |
| 205 | + |
| 206 | + |
| 207 | +def test_sort_and_trim_hot_path_in_place_equivalence(mock_searcher): |
| 208 | + """Searched-type items are reused in place and match the old rebuild output.""" |
| 209 | + inputs = [ |
| 210 | + make_searched_item("m-high", 0.9), |
| 211 | + make_searched_item("m-mid", 0.8), |
| 212 | + make_searched_item("m-low", 0.7), |
| 213 | + ] |
| 214 | + input_items = {item.id: item for item, _ in inputs} |
| 215 | + |
| 216 | + result = mock_searcher._sort_and_trim(inputs, top_k=2) |
| 217 | + |
| 218 | + assert [item.memory for item in result] == ["m-high", "m-mid"] |
| 219 | + for item, score in zip(result, [0.9, 0.8], strict=True): |
| 220 | + # Selected items are the very same objects, relativity overwritten in place. |
| 221 | + assert item is input_items[item.id] |
| 222 | + assert item.metadata.relativity == score |
| 223 | + assert isinstance(item.metadata.relativity, float) |
| 224 | + # Output is exactly what the old dump-and-rebuild path produced. |
| 225 | + assert item.to_dict() == rebuild_like_before(input_items[item.id], score).to_dict() |
| 226 | + |
| 227 | + |
| 228 | +def test_sort_and_trim_cold_path_type_upgrade(mock_searcher): |
| 229 | + """Non-Searched metadata (e.g. graph/bm25 results) is still rebuilt.""" |
| 230 | + original = make_item("graph-mem", 0.8) |
| 231 | + |
| 232 | + result = mock_searcher._sort_and_trim([original], top_k=2) |
| 233 | + |
| 234 | + assert len(result) == 1 |
| 235 | + rebuilt = result[0] |
| 236 | + assert rebuilt is not original[0] # cold path produces a new item |
| 237 | + assert isinstance(rebuilt.metadata, SearchedTreeNodeTextualMemoryMetadata) |
| 238 | + assert rebuilt.metadata.relativity == 0.8 |
| 239 | + assert rebuilt.to_dict() == rebuild_like_before(original[0], 0.8).to_dict() |
| 240 | + |
| 241 | + |
| 242 | +def test_sort_and_trim_mixed_types(mock_searcher): |
| 243 | + """Mixed Searched/TreeNode candidates all come back as Searched with final scores.""" |
| 244 | + inputs = [ |
| 245 | + make_searched_item("hot-1", 0.6), |
| 246 | + make_item("cold-1", 0.95), |
| 247 | + make_searched_item("hot-2", 0.7), |
| 248 | + ] |
| 249 | + |
| 250 | + result = mock_searcher._sort_and_trim(inputs, top_k=3) |
| 251 | + |
| 252 | + assert [item.memory for item in result] == ["cold-1", "hot-2", "hot-1"] |
| 253 | + assert all(isinstance(item.metadata, SearchedTreeNodeTextualMemoryMetadata) for item in result) |
| 254 | + assert [item.metadata.relativity for item in result] == [0.95, 0.7, 0.6] |
| 255 | + |
| 256 | + |
| 257 | +def test_sort_and_trim_beyond_top_k_untouched(mock_searcher): |
| 258 | + """Candidates trimmed away keep the relativity injected at recall time.""" |
| 259 | + inputs = [ |
| 260 | + make_searched_item("keep", 0.9), |
| 261 | + make_searched_item("drop-1", 0.5), |
| 262 | + make_searched_item("drop-2", 0.4), |
| 263 | + ] |
| 264 | + |
| 265 | + result = mock_searcher._sort_and_trim(inputs, top_k=1) |
| 266 | + |
| 267 | + assert [item.memory for item in result] == ["keep"] |
| 268 | + for item, _ in inputs[1:]: |
| 269 | + assert item.metadata.relativity == 0.5 |
| 270 | + |
| 271 | + |
| 272 | +def test_sort_and_trim_plugin_filters_zero_scores(mock_searcher): |
| 273 | + """plugin=True drops candidates whose score rounds to 0.00 without writing.""" |
| 274 | + inputs = [make_searched_item("near-zero", 0.001, relativity=0.42)] |
| 275 | + |
| 276 | + result = mock_searcher._sort_and_trim(inputs, top_k=5, plugin=True) |
| 277 | + |
| 278 | + assert result == [] |
| 279 | + assert inputs[0][0].metadata.relativity == 0.42 |
| 280 | + |
| 281 | + |
| 282 | +def test_sort_and_trim_reuses_input_list_safely(mock_searcher): |
| 283 | + """Calling _sort_and_trim twice on the same candidates is idempotent.""" |
| 284 | + inputs = [ |
| 285 | + make_searched_item("m-1", 0.9), |
| 286 | + make_item("m-2", 0.8), |
| 287 | + ] |
| 288 | + |
| 289 | + first = mock_searcher._sort_and_trim(list(inputs), top_k=2) |
| 290 | + second = mock_searcher._sort_and_trim(list(inputs), top_k=2) |
| 291 | + |
| 292 | + assert [item.to_dict() for item in first] == [item.to_dict() for item in second] |
| 293 | + assert [item.metadata.relativity for item in first] == [0.9, 0.8] |
| 294 | + |
| 295 | + |
| 296 | +def test_sort_and_trim_coerces_numpy_score(mock_searcher): |
| 297 | + """The in-place write applies the same float() coercion pydantic validation did.""" |
| 298 | + item, _score = make_searched_item("np-mem", 0.0) |
| 299 | + |
| 300 | + result = mock_searcher._sort_and_trim([(item, np.float64(0.9))], top_k=1) |
| 301 | + |
| 302 | + assert isinstance(result[0].metadata.relativity, float) |
| 303 | + assert result[0].metadata.relativity == 0.9 |
0 commit comments