Skip to content

CreateMilestoneDto doesn't validate that deadline is in the future, same gap as CreateBountyDto (#108) #171

Description

@chonilius

CreateMilestoneDto.deadline (src/milestones/dto/create-milestone.dto.ts) is validated only with @IsOptional() @IsISO8601() — any syntactically valid ISO-8601 date is accepted, including one already in the past. This is the identical gap already tracked for CreateBountyDto in #108, just in the sibling DTO for milestones — worth fixing together given MilestonesService doesn't have any deadline-expiry handling at all (unlike bounties' expireOverdue), so a past-dated milestone deadline isn't just non-functional at creation time, it has no downstream safety net either.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave programbugSomething isn't workingenhancementNew feature or requestgood first issueGood for newcomershelp wantedExtra attention is needed

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions