Implemented code findings

Author: gabriel-bolbotina

core/merginapi.cpp

@@ -112,6 +112,17 @@ MerginApi::MerginApi( LocalProjectsManager &localProjects, QObject *parent )
     }
   } );
 
+#ifndef QT_NO_SSL
+  QObject::connect(mManager, &QNetworkAccessManager::sslErrors, this, []( QNetworkReply *reply, const QList<QSslError> &errors )
+  {
+    CoreUtils::log( "URL attempting to access:", reply->url().toString());
+    for ( const auto &error : errors )
+    {
+      CoreUtils::log( "Error Description:", error.errorString() );
+    }
+  } );
+#endif
+
   //
   // check if the cache is up to date:
   //  - server url and type
@@ -1887,27 +1898,6 @@ void MerginApi::pingMergin()
   request.setUrl( url );
 
   QNetworkReply *reply = mManager->get( request );
-#ifndef QT_NO_SSL
-  connect( reply, &QNetworkReply::sslErrors, this, [url]( const QList<QSslError> &errors )
-  {
-    CoreUtils::log( "URL attempting to access:", url.toString() );
-    for ( const auto &error : errors )
-    {
-      CoreUtils::log( "Error Description:", error.errorString() );
-      // Get the certificate causing the error
-      QSslCertificate cert = error.certificate();
-      if ( !cert.isNull() )
-      {
-        CoreUtils::log( "Subject (Common Name):", cert.subjectInfo( QSslCertificate::CommonName ).join( "," ) );
-        CoreUtils::log( "Issuer (Common Name):", cert.issuerInfo( QSslCertificate::CommonName ).join( "," ) );
-        CoreUtils::log( "Organization:", cert.subjectInfo( QSslCertificate::Organization ).join( "," ) );
-        CoreUtils::log( "Valid From:", cert.effectiveDate().toString() );
-        CoreUtils::log( "Expires On:", cert.expiryDate().toString() );
-        CoreUtils::log( "Fingerprint (SHA256):", cert.digest( QCryptographicHash::Sha256 ).toHex() );
-      }
-    }
-  } );
-#endif
   CoreUtils::log( "ping", QStringLiteral( "Requesting: " ) + url.toString() );
   connect( reply, &QNetworkReply::finished, this, &MerginApi::pingMerginReplyFinished );
 }