Skip to content

Commit 120ed04

Browse files
authored
chore: Re-enable lint rules with no violations (#7267)
## Explanation These lint rules were temporarily disabled at some point in the past, but we still want to use them. There were no violations for any of these rules, so they have been re-enabled. Whatever violations motivated disabling these must have been incidentally fixed since then. Additionally, the modifications made for `@typescript-eslint/switch-exhaustiveness-check` are now in the shared config, so the override was no longer needed. ## References N/A ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Removes several `off` overrides to re-enable ESLint rules and drops the custom `@typescript-eslint/switch-exhaustiveness-check` config. > > - **ESLint config (`eslint.config.mjs`)**: > - Re-enable defaults by removing `off` overrides for: `function-paren-newline`, `implicit-arrow-linebreak`, `import-x/no-anonymous-default-export`, `lines-around-comment`, `no-invalid-this`, `radix`. > - Remove custom rule config for `@typescript-eslint/switch-exhaustiveness-check`. > - All other rules/settings remain as before. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 25896e0. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent 468b1dc commit 120ed04

File tree

1 file changed

+0
-14
lines changed

1 file changed

+0
-14
lines changed

eslint.config.mjs

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -31,20 +31,14 @@ const config = createConfig([
3131
'id-length': 'off',
3232

3333
// TODO: re-enble most of these rules
34-
'function-paren-newline': 'off',
3534
'id-denylist': 'off',
36-
'implicit-arrow-linebreak': 'off',
37-
'import-x/no-anonymous-default-export': 'off',
3835
'import-x/no-unassigned-import': 'off',
39-
'lines-around-comment': 'off',
4036
'no-async-promise-executor': 'off',
4137
'no-case-declarations': 'off',
42-
'no-invalid-this': 'off',
4338
'no-negated-condition': 'off',
4439
'no-new': 'off',
4540
'no-param-reassign': 'off',
4641
'no-restricted-syntax': 'off',
47-
radix: 'off',
4842
'require-atomic-updates': 'off',
4943
},
5044
settings: {
@@ -115,14 +109,6 @@ const config = createConfig([
115109
},
116110
},
117111
rules: {
118-
// These rules have been customized from their defaults.
119-
'@typescript-eslint/switch-exhaustiveness-check': [
120-
'error',
121-
{
122-
considerDefaultExhaustiveForUnions: true,
123-
},
124-
],
125-
126112
// TODO: Disable in `eslint-config-typescript`, tracked here: https://github.com/MetaMask/eslint-config/issues/413
127113
'@typescript-eslint/no-unnecessary-type-arguments': 'off',
128114

0 commit comments

Comments
 (0)