feat: Add optional force option to updateRemoteFeatureFlags - #9966
Merged
Conversation
weitingsun
approved these changes
Aug 25, 2026
DDDDDanica
approved these changes
Aug 26, 2026
Contributor
|
LGTM ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This PR just adds an optional
forcearg toupdateRemoteFeatureFlagsfor forcing an update whenever it's set to true.Example use case: We'll want to force an update once canonical IDs are available on the platform sides so that the proper flag variants are served
References
Checklist
Note
Low Risk
Backward-compatible optional parameter with narrow cache-bypass behavior; existing callers unchanged when omitting force.
Overview
Adds an optional
forceargument (defaultfalse) toupdateRemoteFeatureFlags, so callers can refresh remote flags from the API even when the cache is still valid—e.g. after a canonical profile ID becomes available so threshold segmentation can be re-fetched.When
forceistrue, the early return that skipped fetch on a fresh cache is bypassed; disabled controllers still never fetch, regardless offorce. Messenger action types, JSDoc, changelog, and tests cover the enabled + forced path and the disabled + forced no-op.Reviewed by Cursor Bugbot for commit 1b71805. Bugbot is set up for automated code reviews on this repo. Configure here.