feat: add rate limit (429) handling to AuthenticationController
#6993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieuartu
changed the title
AuthenticationController
mathieuartu
changed the title
AuthenticationControllerAuthenticationController
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
packages/profile-sync-controller/src/sdk/authentication-jwt-bearer/services.ts
Show resolved
Hide resolved
packages/profile-sync-controller/src/sdk/authentication-jwt-bearer/services.ts
Show resolved
Hide resolved
packages/profile-sync-controller/src/sdk/authentication-jwt-bearer/services.ts
Show resolved
Hide resolved
packages/profile-sync-controller/src/sdk/authentication-jwt-bearer/services.ts
Show resolved
Hide resolved
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
References
Related to: MUL-1214
Checklist
Note
Add 429 rate-limit handling across authentication services and
SRPJwtBearerAuth, including a single retry with configurable cooldown and improved error messaging; add tests and a small time util.src/sdk/authentication-jwt-bearer/services.ts):handleErrorResponsewithRetry-Afterparsing to surfaceRateLimitedErroron HTTP 429 and include HTTP codes in other errors.authenticate,authorizeOIDC,getNonce,pairIdentifiers,getUserProfileLineageto use centralized error handling and rethrow 429s.flow-srp.ts):#loginWithRetryto retry once on 429 with cooldown (default 10s, configurable viarateLimitRetry.cooldownDefaultMs).utils/time.delayand coalesce concurrent logins via in-flight promise map.errors.ts):RateLimitedErrorwith optionalretryAfterMsandisRateLimitErrortype guard.utils/time.tsprovidingdelay(ms).flow-srp.test.tscovering coalesced logins, 429 retry with cooldown, and immediate failure on non-429.CHANGELOG.mdto document rate-limit handling and retry configuration.Written by Cursor Bugbot for commit ee982eb. This will update automatically on new commits. Configure here.