Skip to content

Conversation

@matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Nov 7, 2025

Explanation

Ignore transactions with isTransfer set when checking for duplicate nonces in PendingTransactionTracker.

References

Related to #6135

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Prevents submitted transactions from being marked as dropped by ignoring confirmed incoming/transfer transactions in the duplicate nonce check, with tests and changelog updated.

  • Transaction Controller:
    • Duplicate nonce logic: Update #isNonceTaken in src/helpers/PendingTransactionTracker.ts to ignore transactions where tx.type === \incoming`and any withtx.isTransferset, preventing falsedropped` events.
    • Tests: Add coverage in src/helpers/PendingTransactionTracker.test.ts to ensure no transaction-dropped event when nonce matches an incoming/transfer transaction.
  • Docs:
    • Update packages/transaction-controller/CHANGELOG.md under "Fixed" to note prevention of false dropped status for nonce collisions with incoming transactions.

Written by Cursor Bugbot for commit 8a1f233. This will update automatically on new commits. Configure here.

@matthewwalsh0 matthewwalsh0 marked this pull request as ready for review November 7, 2025 22:58
@matthewwalsh0 matthewwalsh0 requested review from a team as code owners November 7, 2025 22:58
@matthewwalsh0 matthewwalsh0 enabled auto-merge (squash) November 10, 2025 09:23
@matthewwalsh0 matthewwalsh0 force-pushed the fix/incoming-transaction-clash-dropped branch from 77e52f5 to 8a1f233 Compare November 10, 2025 09:23
@matthewwalsh0 matthewwalsh0 merged commit 4fe6a2f into main Nov 10, 2025
271 checks passed
@matthewwalsh0 matthewwalsh0 deleted the fix/incoming-transaction-clash-dropped branch November 10, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants