From c308f63fe2515688ab872cec2429c0aa35c95c1c Mon Sep 17 00:00:00 2001 From: salimtb Date: Thu, 13 Aug 2026 15:27:33 +0200 Subject: [PATCH 1/2] Revert "fix(assets-controller): increase stale and gc time for accounts api request (#9591)" This reverts commit 1b082f70cc15e9c2b80485eec9a4689f5f1995ef. --- packages/assets-controller/CHANGELOG.md | 4 ++++ .../src/data-sources/AccountsApiDataSource.test.ts | 4 ++-- .../src/data-sources/AccountsApiDataSource.ts | 2 +- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/packages/assets-controller/CHANGELOG.md b/packages/assets-controller/CHANGELOG.md index aefa1d0c02..9b4ab5b381 100644 --- a/packages/assets-controller/CHANGELOG.md +++ b/packages/assets-controller/CHANGELOG.md @@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Bump `@metamask/transaction-controller` from `^69.5.1` to `^69.5.2` ([#9823](https://github.com/MetaMask/core/pull/9823)) +### Fixed + +- Revert `AccountsApiDataSource` `forceUpdate` balance fetch cache window from `staleTime`/`gcTime` of `100`ms back to `0`/`0` (undoes [#9591](https://github.com/MetaMask/core/pull/9591)) so forced refreshes truly bypass the TanStack cache instead of reusing a short-lived entry + ## [13.1.2] ### Changed diff --git a/packages/assets-controller/src/data-sources/AccountsApiDataSource.test.ts b/packages/assets-controller/src/data-sources/AccountsApiDataSource.test.ts index 68bf5896a0..e9605355f8 100644 --- a/packages/assets-controller/src/data-sources/AccountsApiDataSource.test.ts +++ b/packages/assets-controller/src/data-sources/AccountsApiDataSource.test.ts @@ -525,7 +525,7 @@ describe('AccountsApiDataSource', () => { controller.destroy(); }); - it('uses a short-lived TanStack cache window when forceUpdate is true', async () => { + it('fetch bypasses TanStack cache when forceUpdate is true', async () => { const { controller, apiClient } = await setupController(); await controller.fetch(createDataRequest({ forceUpdate: true })); @@ -533,7 +533,7 @@ describe('AccountsApiDataSource', () => { expect(apiClient.accounts.fetchV5MultiAccountBalances).toHaveBeenCalledWith( [`eip155:1:${MOCK_ADDRESS}`], undefined, - { staleTime: 100, gcTime: 100 }, + { staleTime: 0, gcTime: 0 }, ); controller.destroy(); diff --git a/packages/assets-controller/src/data-sources/AccountsApiDataSource.ts b/packages/assets-controller/src/data-sources/AccountsApiDataSource.ts index 3de2633e95..5f51b8d8c2 100644 --- a/packages/assets-controller/src/data-sources/AccountsApiDataSource.ts +++ b/packages/assets-controller/src/data-sources/AccountsApiDataSource.ts @@ -428,7 +428,7 @@ export class AccountsApiDataSource extends AbstractDataSource< } const fetchOptions = request.forceUpdate - ? { staleTime: 100, gcTime: 100 } + ? { staleTime: 0, gcTime: 0 } : undefined; // Feature-flagged: v6 endpoint with a fallback to legacy v5. The flag is From c780548a39c5190fce42427a532b83d223b4fa63 Mon Sep 17 00:00:00 2001 From: salimtb Date: Thu, 13 Aug 2026 16:27:46 +0200 Subject: [PATCH 2/2] docs: link assets-controller changelog entry to #9870 --- packages/assets-controller/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/assets-controller/CHANGELOG.md b/packages/assets-controller/CHANGELOG.md index 9b4ab5b381..27e4c6381c 100644 --- a/packages/assets-controller/CHANGELOG.md +++ b/packages/assets-controller/CHANGELOG.md @@ -13,7 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Fixed -- Revert `AccountsApiDataSource` `forceUpdate` balance fetch cache window from `staleTime`/`gcTime` of `100`ms back to `0`/`0` (undoes [#9591](https://github.com/MetaMask/core/pull/9591)) so forced refreshes truly bypass the TanStack cache instead of reusing a short-lived entry +- Revert `AccountsApiDataSource` `forceUpdate` balance fetch cache window from `staleTime`/`gcTime` of `100`ms back to `0`/`0` (undoes [#9591](https://github.com/MetaMask/core/pull/9591)) so forced refreshes truly bypass the TanStack cache instead of reusing a short-lived entry ([#9870](https://github.com/MetaMask/core/pull/9870)) ## [13.1.2]