Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please upgrade hw-app-eth to make it support EIP1559 and EIP2930 #90

Open
gre opened this issue Aug 3, 2021 · 1 comment
Open

Please upgrade hw-app-eth to make it support EIP1559 and EIP2930 #90

gre opened this issue Aug 3, 2021 · 1 comment

Comments

@gre
Copy link

gre commented Aug 3, 2021

Hello,

We have recently merged LedgerHQ/ledgerjs#637
which brings support for EIP1559 and EIP2930 in combination with Nano App v1.8.9 (currently available as a rc1 in Experimental Manager Provider 4 on Ledger Live)

I noticed that you will have to upgrade the library https://github.com/MetaMask/eth-ledger-bridge-keyring/blob/gh-pages/package.json#L23 to make it possible to do such transaction. This needs to be at least v6.3.0 of hw-app-eth (see https://github.com/LedgerHQ/ledgerjs/releases)

the v5 -> v6 shouldn't be breaking. It was made a major bump when we migrated from FlowType to TypeScript but we still target to JS bundle that should work without you to change anything beyond that.

It would be great if you have the ability to test this end to end, but if you can't, we would be happy to test on the matter (if you tell us the combination of what we need to do with MetaMask plugin for it to produce EIP1559 transactions)

Thanks and sorry for such short notice.

@pscott
Copy link

pscott commented Sep 17, 2021

I believe this issue can be closed, but I would like to point out this comment I made on the the other PR (which talks about fixing an important bug wiht eip1559-style tx :)): #95 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants