feat: transaction scan 4 - add transacstion scan service (#101)

## Explanation

This PR introduces transaction-history synchronization and richer
Horizon-derived transaction mapping for the Stellar snap, including
decoding result_xdr for more accurate path-payment (swap/receive)
amounts and persisting per-account scan cursors.

<!--
Thanks for your contribution! Take a moment to answer these questions so
that reviewers have the information they need to properly understand
your changes:

* What is the current state of things and why does it need to change?
* What is the solution your changes offer and how does it work?
* Are there any changes whose purpose might not obvious to those
unfamiliar with the domain?
* If your primary goal was to update one package but you found you had
to update another one along the way, why did you do so?
* If you had to upgrade a dependency, why did you do so?
-->

## References

<!--
Are there any issues that this pull request is tied to?
Are there other links that reviewers should consult to understand these
changes better?
Are there client or consumer pull requests to adopt any breaking
changes?

For example:

* Fixes #12345
* Related to #67890
-->

## Checklist

- [ ] I've updated the test suite for new or updated code as appropriate
- [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [ ] I've communicated my changes to consumers by [updating changelogs
for packages I've
changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md)
- [ ] I've introduced [breaking
changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md)
in this PR and have prepared draft pull requests for clients and
consumer packages to resolve them

Author: stanleyyconsensys

merged-packages/stellar-wallet-snap/src/context.ts

@@ -47,6 +47,7 @@ import {
 } from './services/on-chain-account';
 import { PriceService } from './services/price';
 import { State } from './services/state';
+import { SynchronizeService } from './services/sync/SynchronizeService';
 import {
   TransactionBuilder,
   TransactionRepository,
@@ -68,6 +69,7 @@ const state = new State({
     keyringAccounts: {},
     assets: {},
     transactions: {},
+    lastScanTokens: {},
     onChainAccounts: {} as OnChainAccountState['onChainAccounts'],
   },
 });
@@ -111,6 +113,7 @@ const transactionService = new TransactionService({
   transactionRepository,
   networkService,
   transactionBuilder,
+  assetMetadataService,
 });
 
 const priceService = new PriceService({
@@ -125,6 +128,12 @@ const transactionScanService = new TransactionScanService({
   logger,
 });
 
+const synchronizeService = new SynchronizeService({
+  logger,
+  onChainAccountService,
+  transactionService,
+});
+
 /** UX Controller */
 const confirmationUIController = new ConfirmationUXController({
   logger,
@@ -210,15 +219,14 @@ const refreshConfirmationContextHandler = new RefreshConfirmationContextHandler(
 const trackTransactionHandler = new TrackTransactionHandler({
   logger,
   networkService,
-  onChainAccountService,
+  synchronizeService,
   accountService,
-  transactionService,
 });
 
 const syncAccountsHandler = new SyncAccountsHandler({
   logger,
   accountService,
-  onChainAccountService,
+  synchronizeService,
 });
 
 const cronjobMethodHandlers: Record<

merged-packages/stellar-wallet-snap/src/handlers/cronjob/syncAccounts.test.ts

@@ -6,7 +6,7 @@ import type {
   StellarKeyringAccount,
 } from '../../services/account';
 import { generateMockStellarKeyringAccounts } from '../../services/account/__mocks__/account.fixtures';
-import type { OnChainAccountService } from '../../services/on-chain-account';
+import type { SynchronizeService } from '../../services/sync/SynchronizeService';
 import { Duration } from '../../utils';
 import { logger } from '../../utils/logger';
 
@@ -27,23 +27,22 @@ describe('SyncAccountsHandler', () => {
       getAllSelected: jest.fn(),
       findByIds: jest.fn(),
     };
-    const onChainAccountService: jest.Mocked<
-      Pick<OnChainAccountService, 'synchronize'>
+    const synchronizeService: jest.Mocked<
+      Pick<SynchronizeService, 'synchronize'>
     > = {
       synchronize: jest.fn(),
     };
 
     const handler = new SyncAccountsHandler({
       logger,
       accountService: accountService as unknown as AccountService,
-      onChainAccountService:
-        onChainAccountService as unknown as OnChainAccountService,
+      synchronizeService: synchronizeService as unknown as SynchronizeService,
     });
 
     return {
       handler,
       accountService,
-      onChainAccountService,
+      synchronizeService,
     };
   };
 
@@ -89,7 +88,7 @@ describe('SyncAccountsHandler', () => {
   });
 
   it('synchronizes selected accounts when accountIds is `selected`', async () => {
-    const { handler, accountService, onChainAccountService } = setupTest();
+    const { handler, accountService, synchronizeService } = setupTest();
     const selectedAccounts = [firstAccount, secondAccount];
     accountService.getAllSelected.mockResolvedValue(selectedAccounts);
 
@@ -104,14 +103,14 @@ describe('SyncAccountsHandler', () => {
 
     expect(accountService.getAllSelected).toHaveBeenCalledTimes(1);
     expect(accountService.findByIds).not.toHaveBeenCalled();
-    expect(onChainAccountService.synchronize).toHaveBeenCalledWith(
+    expect(synchronizeService.synchronize).toHaveBeenCalledWith(
       selectedAccounts,
-      AppConfig.selectedNetwork,
+      { scope: AppConfig.selectedNetwork },
     );
   });
 
   it('treats empty params object like selected accounts', async () => {
-    const { handler, accountService, onChainAccountService } = setupTest();
+    const { handler, accountService, synchronizeService } = setupTest();
     const selectedAccounts = [firstAccount];
     accountService.getAllSelected.mockResolvedValue(selectedAccounts);
 
@@ -125,14 +124,14 @@ describe('SyncAccountsHandler', () => {
     await handler.handle(request);
 
     expect(accountService.getAllSelected).toHaveBeenCalledTimes(1);
-    expect(onChainAccountService.synchronize).toHaveBeenCalledWith(
+    expect(synchronizeService.synchronize).toHaveBeenCalledWith(
       selectedAccounts,
-      AppConfig.selectedNetwork,
+      { scope: AppConfig.selectedNetwork },
     );
   });
 
   it('synchronizes accounts fetched by ids when accountIds is an array of account ids', async () => {
-    const { handler, accountService, onChainAccountService } = setupTest();
+    const { handler, accountService, synchronizeService } = setupTest();
     const accountIds = [firstAccount.id, secondAccount.id];
     const accountsByIds = [firstAccount];
     accountService.findByIds.mockResolvedValue(accountsByIds);
@@ -148,9 +147,8 @@ describe('SyncAccountsHandler', () => {
 
     expect(accountService.findByIds).toHaveBeenCalledWith(accountIds);
     expect(accountService.getAllSelected).not.toHaveBeenCalled();
-    expect(onChainAccountService.synchronize).toHaveBeenCalledWith(
-      accountsByIds,
-      AppConfig.selectedNetwork,
-    );
+    expect(synchronizeService.synchronize).toHaveBeenCalledWith(accountsByIds, {
+      scope: AppConfig.selectedNetwork,
+    });
   });
 });

merged-packages/stellar-wallet-snap/src/handlers/cronjob/syncAccounts.ts

@@ -6,7 +6,7 @@ import type {
   AccountService,
   StellarKeyringAccount,
 } from '../../services/account';
-import type { OnChainAccountService } from '../../services/on-chain-account';
+import type { SynchronizeService } from '../../services/sync/SynchronizeService';
 import { Duration, scheduleBackgroundEvent } from '../../utils';
 import { createPrefixedLogger } from '../../utils/logger';
 import type { ILogger } from '../../utils/logger';
@@ -23,17 +23,17 @@ export class SyncAccountsHandler extends CronjobBaseHandler<SyncAccountJsonRpcRe
     });
   }
 
-  readonly #onChainAccountService: OnChainAccountService;
+  readonly #synchronizeService: SynchronizeService;
 
   readonly #accountService: AccountService;
 
   constructor({
     logger,
-    onChainAccountService,
+    synchronizeService,
     accountService,
   }: {
     logger: ILogger;
-    onChainAccountService: OnChainAccountService;
+    synchronizeService: SynchronizeService;
     accountService: AccountService;
   }) {
     const prefixedLogger = createPrefixedLogger(
@@ -44,7 +44,7 @@ export class SyncAccountsHandler extends CronjobBaseHandler<SyncAccountJsonRpcRe
       logger: prefixedLogger,
       requestStruct: SyncAccountJsonRpcRequestStruct,
     });
-    this.#onChainAccountService = onChainAccountService;
+    this.#synchronizeService = synchronizeService;
     this.#accountService = accountService;
   }
 
@@ -75,8 +75,6 @@ export class SyncAccountsHandler extends CronjobBaseHandler<SyncAccountJsonRpcRe
       accounts = await this.#accountService.findByIds(accountIds);
     }
 
-    await this.#onChainAccountService.synchronize(accounts, scope);
-    // TODO:
-    // sync transaction history
+    await this.#synchronizeService.synchronize(accounts, { scope });
   }
 }