fix: add E2E Tests for Multi-RPC Migration and Selection #26851

salimtb · 2024-09-03T09:05:11Z

Description

This PR introduces a series of end-to-end (E2E) tests to validate the functionality of migrating and selecting multiple RPC configurations in the application. These tests cover different scenarios to ensure that the application handles multi-RPC settings correctly, including migrating to a new RPC setup and selecting RPC endpoints from various interfaces.

Related issues

Fixes:

Manual testing steps

Run yarn build:test
Run yarn test:e2e:single test/e2e/tests/network/multi-rpc.spec.ts --browser chrome

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-09-03T09:05:26Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2024-09-19T11:01:14Z

Builds ready [7af4f3d]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1789 ± 96 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	340	2346	1710	370	178
		domContentLoaded	1460	2238	1756	183	88
		load	1470	2352	1789	200	96
		domInteractive	14	79	40	17	8

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -1.68 KiB (-0.04%)
ui: 15.45 KiB (0.21%)
common: 9.21 KiB (0.11%)

ui/components/multichain/dropdown-editor/dropdown-editor.tsx

metamaskbot · 2024-09-20T16:58:58Z

Builds ready [dcb7596]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1845 ± 107 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1567	2440	1841	222	107
		domContentLoaded	1544	2424	1816	223	107
		load	1548	2441	1845	222	107
		domInteractive	14	149	43	30	14

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 32 Bytes (0.00%)
common: 0 Bytes (0.00%)

test/e2e/tests/network/multi-rpc.spec.ts

test/e2e/tests/network/update-network.spec.ts

…-extension into salim/add-e2e-test-v21

sonarcloud · 2024-09-20T18:52:20Z

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

bergeron · 2024-09-20T19:07:25Z

ui/components/multichain/network-list-menu/network-list-menu.tsx

@@ -494,7 +495,7 @@ export const NetworkListMenu = ({ onClose }: { onClose: () => void }) => {
        <AddRpcUrlModal
          onAdded={(url, name) => {
            // Note: We could choose to rename the URL if it already exists with a different name
-            if (rpcUrls.rpcEndpoints?.every((e) => e.url !== url)) {
+            if (rpcUrls.rpcEndpoints?.every((e) => !URI.equal(e.url, url))) {


This matches the validation done by the network controller, which does not allow duplicates, including edge cases like different casing

metamaskbot · 2024-09-20T19:34:36Z

Builds ready [5bc7d1e]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1829 ± 93 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1569	2362	1832	208	100
		domContentLoaded	1557	2296	1800	195	94
		load	1612	2312	1829	193	93
		domInteractive	21	399	55	80	38

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 139 Bytes (0.00%)
common: 0 Bytes (0.00%)

salimtb requested a review from a team as a code owner September 3, 2024 09:05

github-actions bot added the team-assets label Sep 3, 2024

salimtb force-pushed the salim/add-e2e-test-v21 branch 2 times, most recently from 07132fe to 6420d82 Compare September 3, 2024 15:16

salimtb marked this pull request as draft September 17, 2024 13:09

salimtb force-pushed the salim/add-e2e-test-v21 branch 5 times, most recently from e29ac13 to 7af4f3d Compare September 19, 2024 10:19

salimtb marked this pull request as ready for review September 19, 2024 11:37

salimtb requested a review from a team as a code owner September 19, 2024 11:37

Base automatically changed from brian/network-controller-v20-merging-in-v21 to develop September 20, 2024 08:35

bergeron requested review from a team as code owners September 20, 2024 08:35

salimtb added 5 commits September 20, 2024 17:22

fix: add e2e test for multi rpc flow

df63196

fix: addd delete rpc e2e test

6c79774

fix: add new rpc e2e test

37a1345

fix: fix e2e test

fbffec5

fix: add e2e test to check used rpc

dcb7596

salimtb force-pushed the salim/add-e2e-test-v21 branch from 7af4f3d to dcb7596 Compare September 20, 2024 15:27

bergeron removed request for a team September 20, 2024 16:41

bergeron reviewed Sep 20, 2024

View reviewed changes

ui/components/multichain/dropdown-editor/dropdown-editor.tsx Outdated Show resolved Hide resolved

bergeron reviewed Sep 20, 2024

View reviewed changes

test/e2e/tests/network/multi-rpc.spec.ts Show resolved Hide resolved

bergeron reviewed Sep 20, 2024

View reviewed changes

test/e2e/tests/network/multi-rpc.spec.ts Outdated Show resolved Hide resolved

bergeron reviewed Sep 20, 2024

View reviewed changes

test/e2e/tests/network/update-network.spec.ts Outdated Show resolved Hide resolved

bergeron added 6 commits September 20, 2024 10:50

use clickElement instead of finding then clicking

e714047

Merge branch 'develop' into salim/add-e2e-test-v21

5da640b

actually save the network after deletion

2f40494

Merge branch 'salim/add-e2e-test-v21' of github.com:MetaMask/metamask…

028f374

…-extension into salim/add-e2e-test-v21

change update rpc test to actually save

ac3c62a

remove commented out code

5bc7d1e

bergeron reviewed Sep 20, 2024

View reviewed changes

bergeron approved these changes Sep 20, 2024

View reviewed changes

darkwing approved these changes Sep 20, 2024

View reviewed changes

bergeron merged commit df6ee7f into develop Sep 20, 2024
75 of 77 checks passed

bergeron deleted the salim/add-e2e-test-v21 branch September 20, 2024 19:30

github-actions bot locked and limited conversation to collaborators Sep 20, 2024

metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: add E2E Tests for Multi-RPC Migration and Selection #26851

fix: add E2E Tests for Multi-RPC Migration and Selection #26851

salimtb commented Sep 3, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Sep 3, 2024

metamaskbot commented Sep 19, 2024

metamaskbot commented Sep 20, 2024

sonarcloud bot commented Sep 20, 2024

bergeron Sep 20, 2024 •

edited

Loading

metamaskbot commented Sep 20, 2024

fix: add E2E Tests for Multi-RPC Migration and Selection #26851

fix: add E2E Tests for Multi-RPC Migration and Selection #26851

Conversation

salimtb commented Sep 3, 2024 • edited by github-actions bot Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Sep 3, 2024

metamaskbot commented Sep 19, 2024

metamaskbot commented Sep 20, 2024

sonarcloud bot commented Sep 20, 2024

Quality Gate failed

bergeron Sep 20, 2024 • edited Loading

Choose a reason for hiding this comment

metamaskbot commented Sep 20, 2024

salimtb commented Sep 3, 2024 •

edited by github-actions bot

Loading

bergeron Sep 20, 2024 •

edited

Loading